Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow PATCH in enable-cors #1288

Merged
merged 1 commit into from
Sep 2, 2017
Merged

Allow PATCH in enable-cors #1288

merged 1 commit into from
Sep 2, 2017

Conversation

dwelch2344
Copy link
Contributor

While using ingress.kubernetes.io/enable-cors is awesome and super easy to get started with, PATCH was left out. Not sure if this was intentional or not, but would love to see it available.

Thoughts?

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Sep 1, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 1, 2017
@dwelch2344
Copy link
Contributor Author

Should be validated now for CLA

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 1, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 43.586% when pulling 8abbd1a on dwelch2344:master into cda42f9 on kubernetes:master.

@aledbf aledbf self-assigned this Sep 2, 2017
@aledbf
Copy link
Member

aledbf commented Sep 2, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 2, 2017
@aledbf
Copy link
Member

aledbf commented Sep 2, 2017

@dwelch2344 thanks!

@aledbf aledbf merged commit 528cb8b into kubernetes:master Sep 2, 2017
@dwelch2344
Copy link
Contributor Author

Woohoo! Okay, forgive my noobness – how can I track when this goes out? we'll eagerly be awaiting :)

@aledbf
Copy link
Member

aledbf commented Sep 7, 2017

@dwelch2344 we need to release a new version to fix an issue so before the end of the week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants