Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 'worker-shutdown-timeout' #1261

Merged
merged 1 commit into from
Aug 29, 2017

Conversation

maxlaverse
Copy link
Contributor

When reloading the configuration or gracefully shutting down, Nginx waits 10secondes for the workers to exit.

It would be great if we could configure this value through the ConfigMap as it implicitely determines how long we are waiting for open connections to close.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 29, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 29, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+0.007%) to 43.9% when pulling d9e7d1e on maxlaverse:worker_shutdown_timeout into 7844415 on kubernetes:master.

@aledbf aledbf self-assigned this Aug 29, 2017
@aledbf
Copy link
Member

aledbf commented Aug 29, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 29, 2017
@aledbf
Copy link
Member

aledbf commented Aug 29, 2017

@maxlaverse thanks!

@aledbf aledbf merged commit 3fd8abe into kubernetes:master Aug 29, 2017
@maxlaverse maxlaverse deleted the worker_shutdown_timeout branch August 29, 2017 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants