Add resolver configuration to nginx #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
This was referenced Jan 10, 2017
justinsb
reviewed
Jan 12, 2017
| if err != nil { | ||
| glog.Warningf("unexpected error reading system nameservers: %v", err) | ||
| } | ||
| to.Resolver = h |
There was a problem hiding this comment.
Should we do this even if there was an error?
| @@ -53,6 +54,9 @@ func TestMergeConfigMapToStruct(t *testing.T) { | |||
| def.UseProxyProtocol = true | |||
| def.GzipTypes = "text/html" | |||
|
|
|||
| h, _ := dns.GetSystemNameServers() | |||
| def.Resolver = h | |||
There was a problem hiding this comment.
Ditto - presumably only if there was not an error? Although in this case I suspect we fail the test (t.Fatalf) and see what happens...
|
/lgtm |
k8s-ci-robot
added
the
lgtm
haoqing0110
pushed a commit
to stolostron/management-ingress
that referenced
this pull request
Mar 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The nginx revolver configuration is needed when the external authentication annotation is used.