Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option for specific scheme for base url #1198

Merged
merged 3 commits into from
Aug 21, 2017
Merged

Add option for specific scheme for base url #1198

merged 3 commits into from
Aug 21, 2017

Conversation

danielqsj
Copy link
Contributor

Fix #1197

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 21, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 44.415% when pulling a6f82d0 on danielqsj:base-url-scheme into 6ef6343 on kubernetes:master.

@aledbf aledbf self-assigned this Aug 21, 2017
@aledbf
Copy link
Member

aledbf commented Aug 21, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 21, 2017
@aledbf
Copy link
Member

aledbf commented Aug 21, 2017

@danielqsj thanks!

@aledbf aledbf merged commit 827d852 into kubernetes:master Aug 21, 2017
@danielqsj danielqsj mentioned this pull request Nov 16, 2018
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aledbf aledbf

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@danielqsj @k8s-reviewable @coveralls @aledbf @k8s-ci-robot