Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the version of echoserver for creating app #1006

Merged
merged 1 commit into from
Jul 24, 2017
Merged

Change the version of echoserver for creating app #1006

merged 1 commit into from
Jul 24, 2017

Conversation

chentao1596
Copy link

@chentao1596 chentao1596 commented Jul 24, 2017 •
edited
Loading

I think the yaml file should be changed because of the change of echoserver's version, thank you!

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 24, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage remained the same at 43.912% when pulling 343a9f3 on chentao1596:change-echoserver-version into 1a26aa2 on kubernetes:master.

@aledbf aledbf self-assigned this Jul 24, 2017
@aledbf
Copy link
Member

aledbf commented Jul 24, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 24, 2017
@aledbf
Copy link
Member

aledbf commented Jul 24, 2017

@chentao1596 thanks!

@aledbf aledbf merged commit 3086b32 into kubernetes:master Jul 24, 2017
@chentao1596 chentao1596 mentioned this pull request Oct 12, 2018
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aledbf aledbf

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@chentao1596 @k8s-reviewable @coveralls @aledbf @k8s-ci-robot @chentao11596