Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nginx ingress - Incorrect logging IP #334

Closed
ese opened this issue Feb 24, 2017 · 4 comments · Fixed by #347
Closed

Nginx ingress - Incorrect logging IP #334

ese opened this issue Feb 24, 2017 · 4 comments · Fixed by #347

Comments

@ese
Copy link

ese commented Feb 24, 2017

Upgrade to nginx-ingress from 0.8.3 to 0.9.0-beta.2 stop to logging correctly IPs and start to log all like if it come from localhost

log before upgrade (nginx-controller 0.8.3):

111.93.xx.xx - [111.93.xx.xx] - - [23/Feb/2017:10:08:21 +0000] "GET /js/main.css HTTP/2.0" 304 212 "deleted" "deleted" 117 0.005 100.96.13.7:3000 0 0.005 304

log after (nginx-controller 0.9.0-beta.2)

- [127.0.0.1] - - [24/Feb/2017:09:37:45 +0000] "GET /fonts/Gotham-Light.woff HTTP/2.0" 304 213 "deleted" "deleted" 260 0.006 [service-3000] 100.96.14.20:3000 0 0.006 304

Nginx controller behind ELB exposed with a service using service.beta.kubernetes.io/aws-load-balancer-proxy-protocol: '*' annotation and type: LoadBalancer
Configured with use-proxy-protocol: "true"

@aledbf
Copy link
Member

aledbf commented Feb 25, 2017

@ese this is a known issue. This will be resolved in the next version

@cehoffman
Copy link

I'm not sure this fixed all client source ip problems. In 0.8.3 X-Forwarded-For contained the client IP, but in beta.5 the X-Forwarded-For header contains 127.0.0.1

@nailgun
Copy link
Contributor

nailgun commented May 11, 2017

+1 beta.5 still have this issue

@cehoffman
Copy link

Looking forward to a new release including #675, which should fix this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants