Question: Nginx Conf: in 'upstream' context, aren't "hash" and "least_conn" stanza conflicting ?

[JordanP]

First of all, thanks for your awesome, tremendous, impressive work.

I am using the new upstream-hash-by annotation introduced in #1490 (I love it ! makes my life so much easier, I had to hack rootfs/etc/nginx/template/ before that...). So the generated upstream block in my Nginx conf looks like:

    upstream default-rocco-5555 {
        # Load balance algorithm; empty for round robin, which is the default
        least_conn;
        hash $request_uri consistent;
        keepalive 32;
        server 10.132.0.21:5555 max_fails=0 fail_timeout=0;
        server 10.132.0.24:5555 max_fails=0 fail_timeout=0;
        server 10.132.0.3:5555 max_fails=0 fail_timeout=0;
        server 10.132.0.37:5555 max_fails=0 fail_timeout=0;
        server 10.132.0.5:5555 max_fails=0 fail_timeout=0;
        server 10.132.0.6:5555 max_fails=0 fail_timeout=0;
        server 10.132.0.8:5555 max_fails=0 fail_timeout=0;
    }

I find that both least_conn and hash being present is weird. I've browsed the Internet and I didn't find any example were both are defined. https://www.nginx.com/blog/choosing-nginx-plus-load-balancing-techniques/ makes me believe that they could be conflicting or that it doesn"t make sense to have both.

What do you think ?

[aledbf]

@JordanP thank you for the report. You are right, we need to remove the load balance algorithm when has is being used. I will open a PR to fix this.

[aledbf]

Closing. Fixed in #1858