This repository has been archived by the owner on Sep 24, 2021. It is now read-only.
setting cni network plugins dynamically #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
heartlock
force-pushed
the
set-cni-dynamically
branch
from
8f47b0a
to
72100ee
Compare
Please update the dockershim vendor. |
|
@feiskyer Will we wait after kubernetes 1.6 final release to merge this, or we are OK since we already released 0.1 for k8s? |
|
@resouer Yep, we could continue fixing our bugs. @heartlock There is also a check in |
heartlock
force-pushed
the
set-cni-dynamically
branch
from
72100ee
to
dd9f241
Compare
heartlock
force-pushed
the
set-cni-dynamically
branch
from
dd9f241
to
058c956
Compare
heartlock
force-pushed
the
set-cni-dynamically
branch
from
058c956
to
486c9cd
Compare
|
test fail related with hyperhq/hyperd#559, I'll take a look at this. |
@heartlock |
heartlock
force-pushed
the
set-cni-dynamically
branch
from
486c9cd
to
4e67a3b
Compare
|
updated it @feiskyer |
|
@heartlock LGTM. Thanks. /lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #110
if we want to use kubernetes/kubernetes#43474 in dockershim in frakti, kubernetes vendor must be updated. @feiskyer