Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node Conformance Test #84

Closed
7 of 18 tasks
dchen1107 opened this issue Aug 26, 2016 · 14 comments
Closed
7 of 18 tasks

Node Conformance Test #84

dchen1107 opened this issue Aug 26, 2016 · 14 comments
Assignees
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/node Categorizes an issue or PR as relevant to SIG Node.

Comments

@dchen1107
Copy link
Member

dchen1107 commented Aug 26, 2016

Description

Node Conformance Test (This is part of Kubernetes NodeSpec effort: #56)

Progress Tracker

FEATURE_STATUS is used for feature tracking and to be updated by @kubernetes/feature-reviewers.
FEATURE_STATUS: IN_DEVELOPMENT

More advice:

Design

  • Once you get LGTM from a @kubernetes/feature-reviewers member, you can check this checkbox, and the reviewer will apply the "design-complete" label.

Coding

  • Use as many PRs as you need. Write tests in the same or different PRs, as is convenient for you.
  • As each PR is merged, add a comment to this issue referencing the PRs. Code goes in the http://github.com/kubernetes/kubernetes repository,
    and sometimes http://github.com/kubernetes/contrib, or other repos.
  • When you are done with the code, apply the "code-complete" label.
  • When the feature has user docs, please add a comment mentioning @kubernetes/feature-reviewers and they will
    check that the code matches the proposed feature and design, and that everything is done, and that there is adequate
    testing. They won't do detailed code review: that already happened when your PRs were reviewed.
    When that is done, you can check this box and the reviewer will apply the "code-complete" label.

Docs

  • Write user docs and get them merged in.
  • User docs go into http://github.com/kubernetes/kubernetes.github.io.
  • When the feature has user docs, please add a comment mentioning @kubernetes/docs.
  • When you get LGTM, you can check this checkbox, and the reviewer will apply the "docs-complete" label.
@dchen1107 dchen1107 added this to the v1.4 milestone Aug 26, 2016
@dchen1107 dchen1107 added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Aug 26, 2016
@dchen1107
Copy link
Member Author

cc/ @aronchick

@janetkuo
Copy link
Member

janetkuo commented Sep 2, 2016

Do we need docs for this task?

@jaredbhatti
Copy link

Ping. Any need for docs?

@Random-Liu
Copy link
Member

@dchen1107 The last PR kubernetes/kubernetes#31093 is not merged, so I don't think we can add doc for this feature currently.

Should we punt this to 1.5?

@dchen1107
Copy link
Member Author

It labeled with alpha-in-1.4 already, and we should provide doc for users. The user doc shouldn't be blocked by kubernetes/kubernetes#31093. Talked to @Random-Liu he is working on user doc now.

@jaredbhatti
Copy link

@dchen1107 @Random-Liu Another ping on docs. Any PRs you can point me to? Does this still need docs?

@Random-Liu
Copy link
Member

@jaredbhatti The doc is pending here kubernetes/website#1216. :)

@idvoretskyi
Copy link
Member

@Random-Liu @dchen1107 @kubernetes/sig-node so, is there any ogoing progress in 1.5 scope?

@Random-Liu
Copy link
Member

Random-Liu commented Nov 22, 2016

Update of this feature for 1.5:

Things left for this feature:

@dchen1107
/cc @kubernetes/sig-node

@dchen1107 dchen1107 modified the milestones: v1.5, v1.4 Nov 22, 2016
@Random-Liu
Copy link
Member

The document PR is ready for review kubernetes/website#1784.

@davidopp davidopp mentioned this issue Dec 4, 2016
22 tasks
@idvoretskyi
Copy link
Member

@dchen1107 can you confirm that this item targets stable in 1.6?

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 2, 2018
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 7, 2018
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

ingvagabund pushed a commit to ingvagabund/enhancements that referenced this issue Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/node Categorizes an issue or PR as relevant to SIG Node.
Projects
None yet
Development

No branches or pull requests

8 participants