Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KEP-1281: Clarify beta status. #3992

Merged
merged 1 commit into from
May 25, 2023
Merged

Conversation

jkh52
Copy link
Contributor

@jkh52 jkh52 commented May 8, 2023

  • One-line PR description: Clarify that status is beta; introduce GA criteria.
  • Other comments:

This KEP has been a bit dormant, but the Konnectivity Proxy has had several rounds of bugfixes, and recent releases have a good operational track record. We should graduate it from beta to GA, especially since ssh tunnels support is removed.

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 8, 2023
@jkh52
Copy link
Contributor Author

jkh52 commented May 8, 2023

/assign @cheftako

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 8, 2023
@k8s-ci-robot k8s-ci-robot requested a review from jpbetz May 8, 2023 21:00
@k8s-ci-robot k8s-ci-robot added the kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory label May 8, 2023
@k8s-ci-robot k8s-ci-robot requested a review from lavalamp May 8, 2023 21:00
@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label May 8, 2023
@jkh52
Copy link
Contributor Author

jkh52 commented May 8, 2023

/assign @deads2k
/assign @jpbetz

@jkh52 jkh52 force-pushed the knp-ga branch 2 times, most recently from 6a4793d to 772c53b Compare May 9, 2023 17:32
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 22, 2023
@jkh52 jkh52 changed the title KEP-1281: Draft GA criteria. KEP-1281: Clarify beta status. May 22, 2023
@jkh52
Copy link
Contributor Author

jkh52 commented May 22, 2023

Per kubernetes/kubernetes#88502, this enhancement did become beta in 2020, but it wasn't recorded here. This PR minimally updates the status.

It doesn't seem to make much difference, except that instead of two milestones / efforts, there will be one combined effort that should review all graduation aspects. Actually I much prefers this, because with the timeline and stabilization effort, I would not want to take risky / breaking changes.

@jkh52 jkh52 marked this pull request as ready for review May 22, 2023 23:43
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 22, 2023
@cheftako
Copy link
Member

cheftako commented May 25, 2023

/lgtm
Seems correct to me.
As per David I would still like us to prioritize the establishing/agreeing to the GA criteria.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 25, 2023
@deads2k
Copy link
Contributor

deads2k commented May 25, 2023

/lgtm
Seems correct to me.
As per David I would still like us to prioritize the establishing/agreeing to the GA criteria.

Yes.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, jkh52

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 25, 2023
@k8s-ci-robot k8s-ci-robot merged commit 8f39472 into kubernetes:master May 25, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone May 25, 2023
@wojtek-t
Copy link
Member

/lgtm
Seems correct to me.
As per David I would still like us to prioritize the establishing/agreeing to the GA criteria.

Yes.

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants