From 61a690bb4b7284ec0ff84564f2afa9014436998d Mon Sep 17 00:00:00 2001 From: NickrenREN Date: Thu, 30 May 2019 15:39:40 +0800 Subject: [PATCH] PV health monitor --- .../sig-storage/20190530-pv-health-monitor.md | 575 ++++++++++++++++++ 1 file changed, 575 insertions(+) create mode 100644 keps/sig-storage/20190530-pv-health-monitor.md diff --git a/keps/sig-storage/20190530-pv-health-monitor.md b/keps/sig-storage/20190530-pv-health-monitor.md new file mode 100644 index 00000000000..62a1a939772 --- /dev/null +++ b/keps/sig-storage/20190530-pv-health-monitor.md @@ -0,0 +1,575 @@ +--- +title: PV Health Monitor +authors: + - "@NickrenREN" + - "@xing-yang" +owning-sig: sig-storage +reviewers: + - "@msau42" + - "@jingxu97" + - "@liggitt" + - "@gnufied" +approvers: + - "@msau42" + - "@saad-ali" + - "@thockin" + - "@liggitt" +editor: TBD +creation-date: 2019-05-30 +last-updated: 2020-01-23 +status: implementable + +--- + +# PV Health Monitor + +## Table of Contents + + +- [Motivation](#motivation) +- [User Experience](#user-experience) + - [Use Cases](#use-cases) +- [Proposal](#proposal) +- [Implementation](#implementation) + - [CSI changes](#csi-changes) + - [Add GetVolume RPC](#add-getvolume-rpc) + - [Add Node Volume Health Function](#add-node-volume-health-function) + - [External controller](#external-controller) + - [CSI interface](#csi-interface) + - [Node down event](#node-down-event) + - [External node agent](#external-node-agent) + - [CSI interface](#csi-interface-1) + - [Alternatives](#alternatives) + - [Alternative option 1](#alternative-option-1) + - [Alternative option 2](#alternative-option-2) + - [Alternative option 3](#alternative-option-3) + - [Optional HTTP(RPC) service](#optional-httprpc-service) +- [Graduation Criteria](#graduation-criteria) + - [Alpha -> Beta](#alpha---beta) + - [Beta -> GA](#beta---ga) +- [Test Plan](#test-plan) + - [Unit tests](#unit-tests) + - [E2E tests](#e2e-tests) +- [Implementation History](#implementation-history) + + +## Motivation + +Currently there is no way to monitor Persistent Volumes after they are provisioned in Kubernetes. This makes it very hard to debug and detect root causes when something happens to the volumes. An application may detect that it can no longer write to volumes. However, the root cause happened at the underlying storage system level. This requires application and infrastructure team jointly debug and find out what has triggered the problem. It could be that the volume runs out of capacity and needs an expansion. It could be that the volume was deleted by accident outside of Kubernetes. In the case of local storage, the local PVs may not be accessed any more due to the nodes break down. In either case, it will take lots of effort to find out what has happened at the infrastructure layer. It will also take complicated process to recover. Admin usually needs to intervene and fix the problem. + +With health monitoring, unhealthy volumes can be detected and fixed early and therefore could prevent more serious problems to occur. While some problems may be corrected automatically by a Kubernetes controller, most problems may involve manual admin intervention or need to be fixed with specific application knowledge. In any case, volume health monitoring is a very important tool that would be beneficial to Kubernetes users. + +## User Experience + +### Use Cases + +Many things could happen to the underlying storage system after a volume is provisioned in Kubernetes. + +* Volume could be deleted by accident outside of Kubernetes. +* The disk that the volume resides on could be removed temporarily for maintenance. +* The disk that the volume resides on could fail. +* There may be configuration issues with the underlying storage system that affect the volume’s health. +* Volume could be out of capacity. +* The disk may be degrading which affects its performance. + +If the volume is mounted on a pod and used by an application, the following problems could also happen. +* There may be read/write I/O errors. +* The file system on the volume may be corrupted. +* Filesystem may be out of capacity. +* Volume may be unmounted by accident outside of Kubernetes. + +If the CSI driver has implemented the CSI volume health function proposed in this design document, Kubernetes could communicate with the CSI driver to retrieve any errors detected by the underlying storage system. Kubernetes can report an event and log an error about this PVC so that user can inquire this information and decide how to handle them. For example, if the volume is out of capacity, user can request a volume expansion to get more space. In the first phase, volume health monitoring is informational only as it is only reported in the events and logs. In the future, we will also look into how Kubernetes may use volume health information to automatically reconcile. + +There could be conditions that cannot be reported by a CSI driver. One or more nodes where the volume is attached to may be down. This can be monitored and detected by the volume health controller so that user knows what has happened. + +The Kubernetes components that monitor the volumes and report events with volume health information include the following: + +* An external monitoring node agent on each kubernetes worker node. +* An external monitoring controller on the master node. + +Details will be described in the following proposal section. + +## Proposal + +Volume monitoring is the main focus of this proposal. Reactions are not in the scope of this proposal. + +The following area will be the focus of this proposal at first: + +* Provide a mechanism for CSI drivers to report volume health problems at the controller and node levels. + +Two main parts are involved here in the architecture. + +- External Controller: + - The external controller will be deployed as a sidecar together with the CSI controller driver, similar to how the external-provisioner sidecar is deployed. + - Trigger controller RPC to check the health condition of the CSI volumes. + - The external controller sidecar will also watch for node failure events. + +- External Node Agent: + - The external node agent will be deployed as a sidecar together with the CSI node driver on every Kubernetes worker node. + - Trigger node RPC to check volume's mounting conditions. + - Note that currently we do not have CSI support for local storage. When the support is available, we will implement relavant CSI monitoring interfaces as well. + +## Implementation + +### CSI changes + +Container Storage Interface (CSI) specification will be modified to provide volume health check leveraging existing RPCs and adding new ones. + +- Add new GetVolume controller RPC + - External controller calls a new `GetVolume` RPC to check health condition of a particular PV instead of calling `ListVolumes` with a `volume_id` filter. Some CSI drivers chose not to implement `ListVolumes` as it is an expensive operation. Therefore it is better to introduce a new RPC `GetVolume` which has a new capability. +- Extend the existing NodeGetVolumeStats RPC + - For any PV that is mounted, the external node agent calls `NodeGetVolumeStats` to see if volume is still mounted; + - Calls `NodeGetVolumeStats` to check if volume is usable, e.g., filesystem corruption, bad blocks, etc. + +Two new controller capabilities are added. If a CSI driver supports `GET_VOLUME` capability, it MUST support calling `GetVolume` to provide general volume information in `GetVolumeResponse`. If a driver supports `GET_VOLUME_HEALTH`, it MUST provide additional health information in `GetVolumeResponse`. + +A new node capability is added. If CSI driver supports the `GET_VOLUME_STATS_HEALTH` capability, it MUST provide health information in `NodeGetVolumeStats`. + +Detailed changes needed in the CSI Spec are described in the following. + +#### Add GetVolume RPC + +Add a new `GetVolume` RPC. `GetVolumeResponse` should contain current information of a volume if it exists. If the volume does not exist any more, `GetVolume` should return gRPC error code `NOT_FOUND`. + +Add `VolumeHealth` message in `VolumeStatus` field in `GetVolumeResponse`. This can indicate additional health information for the volume. + +Whether the volume is still attached to a node is already handled by `LIST_VOLUMES_PUBLISHED_NODES` controller capability. This capability will be used by Kubernetes to reconcile - re-attach the volume if the volume is not attached any more. + +``` +message GetVolumeRequest { + // Identity information for a specific volume. This field is + // REQUIRED. GetVolume will return with current volume information. + string volume_id = 1; +} +``` + +``` +message GetVolumeResponse { + message VolumeStatus{ + // health shows error conditions reported by the SP. + // This field MUST be specified if the + // GET_VOLUME_HEALTH controller capability is supported. + repeated VolumeHealth health = 1; + } + + // This field is REQUIRED + Volume volume = 1; + + // This field is OPTIONAL. This field MUST be specified if the + // GET_VOLUME_HEALTH controller capability is supported. + VolumeStatus status = 2; +} +``` + +``` +message VolumeHealth { + // The error code describing the health condition of the volume. + // This field is REQUIRED. + string error_code = 1; + + // The error message associated with the above error_code. This field is OPTIONAL. + string message = 2; +} +``` + +The following common error codes are proposed for volume health: +* VolumeNotFound +* OutOfCapacity +* DiskFailure +* DiskRemoved +* ConfigError +* NetworkError +* DiskDegrading +* VolumeUnmounted +* RWIOError +* FilesystemCorruption + +Add `GET_VOLUME` and `GET_VOLUME_HEALTH` controller capabilities. If a driver supports `GET_VOLUME` capability, it MUST implement the `GetVolume` RPC. If a driver supports `GET_VOLUME_HEALTH`, it MUST supports the `health` field in the `status` field in `GetVolumeResponse`. + +``` +// Specifies a capability of the controller service. +message ControllerServiceCapability { + message RPC { + enum Type { + UNKNOWN = 0; + CREATE_DELETE_VOLUME = 1; + PUBLISH_UNPUBLISH_VOLUME = 2; + LIST_VOLUMES = 3; + GET_CAPACITY = 4; + // Currently the only way to consume a snapshot is to create + // a volume from it. Therefore plugins supporting + // CREATE_DELETE_SNAPSHOT MUST support creating volume from + // snapshot. + CREATE_DELETE_SNAPSHOT = 5; + LIST_SNAPSHOTS = 6; + + // Plugins supporting volume cloning at the storage level MAY + // report this capability. The source volume MUST be managed by + // the same plugin. Not all volume sources and parameters + // combinations MAY work. + CLONE_VOLUME = 7; + + // Indicates the SP supports ControllerPublishVolume.readonly + // field. + PUBLISH_READONLY = 8; + + // See VolumeExpansion for details. + EXPAND_VOLUME = 9; + + // Indicates the SP supports the + // ListVolumesResponse.entry.published_nodes field + LIST_VOLUMES_PUBLISHED_NODES = 10; + + // Indicates the SP supports the GetVolume RPC + GET_VOLUME = 11; + + // Indicates the SP supports the + // GetVolumeResponse.volume_health field + GET_VOLUME_HEALTH = 12; + } + + Type type = 1; + } + + oneof type { + // RPC that the controller supports. + RPC rpc = 1; + } +} +``` + +#### Add Node Volume Health Function + +Node Volume Health checks if a volume is still mounted and usable. To check whether a volume is usable, the CSI driver shall check if filesystem is corrupted, whether there are bad blocks, etc. in this RPC. + +Instead of adding a new RPC, we can leverage the existing NodeGetVolumeStats RPC. + +``` +rpc NodeGetVolumeStats (NodeGetVolumeStatsRequest) + returns (NodeGetVolumeStatsResponse) {} +``` + +In the NodeGetVolumeStatsRequest, there are `volume_id`, `volume_path`, and `staging_target_path`. CSI driver can figure out whether a volume is still mounted based on these parameters. + +In NodeGetVolumeStatsResponse, there is already a `VolumeUsage` which includes information (available, used, and total) of the file system on the volume. + +A new message `VolumeHealth` will be added to `NodeGetVolumeStatsResponse`. A new Node capability `VOLUME_STATS_HEALTH` will be added to indicate whether a CSI driver has implemented this function. In a `VolumeHeath` message, there is an error code indicating the type of code and a message that describes the details of the error. + +``` +message NodeGetVolumeStatsRequest { + // The ID of the volume. This field is REQUIRED. + string volume_id = 1; + + // It can be any valid path where volume was previously + // staged or published. + // It MUST be an absolute path in the root filesystem of + // the process serving this request. + // This is a REQUIRED field. + string volume_path = 2; + + // The path where the volume is staged, if the plugin has the + // STAGE_UNSTAGE_VOLUME capability, otherwise empty. + // If not empty, it MUST be an absolute path in the root + // filesystem of the process serving this request. + // This field is OPTIONAL. + string staging_target_path = 3; +} +``` + +``` +message NodeGetVolumeStatsResponse { + // This field is OPTIONAL. + repeated VolumeUsage usage = 1; + // This field is OPTIONAL. + repeated VolumeHealth volume_health = 1; +} +``` + +``` +message VolumeUsage { + enum Unit { + UNKNOWN = 0; + BYTES = 1; + INODES = 2; + } + // The available capacity in specified Unit. This field is OPTIONAL. + // The value of this field MUST NOT be negative. + int64 available = 1; + + // The total capacity in specified Unit. This field is REQUIRED. + // The value of this field MUST NOT be negative. + int64 total = 2; + + // The used capacity in specified Unit. This field is OPTIONAL. + // The value of this field MUST NOT be negative. + int64 used = 3; + + // Units by which values are measured. This field is REQUIRED. + Unit unit = 4; +} +``` + +``` +message VolumeHealth { + // The error code describing the health condition of the volume. + // This field is REQUIRED. + string error_code = 1; + + // The error message associated with the above error_code. This field is OPTIONAL. + string message = 2; +} +``` + +Add a `GET_VOLUME_STATS_HEALTH` node capability. If driver supports this capability, it MUST fetch `volume_health` information in `NodeGetVolumeStats`. + +``` +message NodeGetCapabilitiesRequest { + // Intentionally empty. +} +``` + +``` +message NodeGetCapabilitiesResponse { + // All the capabilities that the node service supports. This field + // is OPTIONAL. + repeated NodeServiceCapability capabilities = 1; +} +``` + +``` +// Specifies a capability of the node service. +message NodeServiceCapability { + message RPC { + enum Type { + UNKNOWN = 0; + STAGE_UNSTAGE_VOLUME = 1; + // If Plugin implements GET_VOLUME_STATS capability + // then it MUST implement NodeGetVolumeStats RPC + // call for fetching volume statistics. + GET_VOLUME_STATS = 2; + // See VolumeExpansion for details. + EXPAND_VOLUME = 3; + // If Plugin implements GET_VOLUME_STATS_HEALTH capability + // then it MUST implement NodeGetVolumeStats RPC + // call for fetching volume health information. + GET_VOLUME_STATS_HEALTH = 4; + } + + Type type = 1; + } + + oneof type { + // RPC that the controller supports. + RPC rpc = 1; + } +} +``` + +### External controller + +#### CSI interface +Call GetVolume() RPC for volumes periodically to check the health condition of volumes themselves. The frequency of the check should be tunable. A configure option will be available in the external controller to adjust this value. + +#### Node down event +* External monitoring controller will check if node is marked as unresponsive by the node controller. +* The external monitoring controller will track which pods are using which PVCs and what nodes they got scheduled to. +* In the case that a node goes down, the controller will report an event for all PVCs on that node. + +### External node agent + +#### CSI interface +Call NodeGetVolumeStats() RPC to check the mounting and other health conditions. The frequency of the check should be tunable. A configure option will be available in the external node agent to adjust this value. + +The external node agent will go through all the pods on that node and find out all volumes used by those pods. It will watch all those volumes and call NodeGetVolumeStatus() to find out their health status. + +### Alternatives + +#### Alternative option 1 + +The Status field in the PVC will be used to mark volumes if they are unhealthy. The external monitoring controller sidecar will be responsible of monitoring the volumes and updating the PVC status field when needed. + +``` +// PersistentVolumeClaimHealthConditionType defines the health condition of PV claim. +// Valid values are "HealthFailure", "HealthWarning", "HealthUnknown". +type PersistentVolumeClaimHealthConditionType string + +// These are valid health conditions of PVC +const ( + // PersistentVolumeClaimHealthFailure - Volume health failure indicates a severe problem that makes the volume unusable + PersistentVolumeClaimHealthFailure PersistentVolumeClaimHealthConditionType = "HealthFailure" + // PersistentVolumeClaimHealthWarning - Volume health warning indicates there is a problem but volume is still usable + PersistentVolumeClaimHealthWarning PersistentVolumeClaimHealthConditionType = "HealthWarning" + // PersistentVolumeClaimHealthUnknown - Volume health unknown indicates the health condition of the volume is unknown + PersistentVolumeClaimHealthUnknown PersistentVolumeClaimHealthConditionType = "HealthUnknown" +) + +// PersistentVolumeClaimHealthCondition represents the current health condition of PV claim +type PersistentVolumeClaimHealthCondition struct { + Type PersistentVolumeClaimHealthConditionType + Status ConditionStatus + ErrorCode string + // +optional + LastProbeTime metav1.Time + // +optional + LastTransitionTime metav1.Time + // +optional + Reason string + // +optional + Message string +} + +// PersistentVolumeClaimStatus represents the status of PV claim +type PersistentVolumeClaimStatus struct { + // Phase represents the current phase of PersistentVolumeClaim + // +optional + Phase PersistentVolumeClaimPhase + // AccessModes contains all ways the volume backing the PVC can be mounted + // +optional + AccessModes []PersistentVolumeAccessMode + // Represents the actual resources of the underlying volume + // +optional + Capacity ResourceList + // +optional + Conditions []PersistentVolumeClaimCondition + // +optional + HealthConditions []PersistentVolumeClaimHealthCondition +} + +// ConditionStatus defines conditions of resources +type ConditionStatus string + +// These are valid condition statuses. "ConditionTrue" means a resource is in the condition; +// "ConditionFalse" means a resource is not in the condition; "ConditionUnknown" means kubernetes +// can't decide if a resource is in the condition or not. In the future, we could add other +// intermediate conditions, e.g. ConditionDegraded. +const ( + ConditionTrue ConditionStatus = "True" + ConditionFalse ConditionStatus = "False" + ConditionUnknown ConditionStatus = "Unknown" +) +``` + +To avoid stale information being stored on a PVC, each periodic update will mark the PVC with the latest health information, replacing previous health information added by the external controller. If the PVC becomes healthy after being marked as unhealthy previously, the controller should remove the previous information. + +As mentioned earlier, reaction is not in the scope of this proposal but will be considered in the future. Before reacting to any negative health condition, the controller responsible for the reaction should call GetVolume() again to ensure the information is update to date. + +Alternative option 1 is not in the main proposal because it requires giving all nodes access to a credential that has the ability to modify all PVCs. This is not desirable as it allows a malicious node to put an unhealthy status on a PVC. + +#### Alternative option 2 + +If the agent on the node cannot be used to modify the PVC status and the monitoring logic cannot be added to Kubelet directly, we can introduce a CRD to represent the volume health. This volume health CRD is in the same namespace as the PVC that it is monitoring. It contains the PVC name and health conditions as defined in the main option. It needs to have a one on one mapping with the PVC. In the PVC status, there will be a `volumeHealthName` field pointing back to the volume health CRD. + +Both the controller and the agent can create the volume health CRD for a PVC if it does not exist yet. Only one volume health CRD should be created for a PVC. Only the controller can set the `volumeHealthName` field in the PVC status. + +``` +type VolumeHealth struct { + metav1.TypeMeta + metav1.ObjectMeta + Spec VolumeHealthSpec + // +optional + Status *VolumeHealthStatus +} + +type VolumeHealthSpec struct { + // The PVC name that this VolumeHealth object is monitoring + PersistentVolumeClaimName string +} + +// Note: PersistentVolumeClaimHealthCondition is already defined in the +// main section. +type VolumeHealthStatus struct { + HealthConditions []PersistentVolumeClaimHealthCondition +} + +// PersistentVolumeClaimStatus represents the status of PV claim +type PersistentVolumeClaimStatus struct { + // Phase represents the current phase of PersistentVolumeClaim + // +optional + Phase PersistentVolumeClaimPhase + // AccessModes contains all ways the volume backing the PVC can be mounted + // +optional + AccessModes []PersistentVolumeAccessMode + // Represents the actual resources of the underlying volume + // +optional + Capacity ResourceList + // +optional + Conditions []PersistentVolumeClaimCondition + // +optional + VolumeHealthName *string +} +``` + +Alternative option 2 does not address the concerns from option 1. Assuming the node-level sidecar is running in a pod as a service account, we need to grant that service account permission to modify any instance of the volume health CR, and then the monitoring controller just copies that into the PVC status. + +#### Alternative option 3 + +We can also reuse the PV Taints and introduce a new Taint called PVUnhealthMessage for PV health condition whose key is specific (PVUnhealthMessage) and value can be set differently. + +For example, if the PV is not attached now, we can mark the PV using the PVUnhealthMessage taint like this: +``` +Key: “PVUnhealthMessage” +Value: “AttachError - the pv is not attached to node1 now” +VolumeTaintEffect: NoEffect +``` + +If the volume is deleted, we can mark the PV using the PVUnhealthMessage taint like this: +``` +Key: “PVUnhealthMessage” +Value: “VolumeError - the volume is deleted from backend” +VolumeTaintEffect: NoEffect +``` + +Note that: + +- all the VolumeTaintEffects are NoEffect now at first, we may talk about the reactions later in another proposal; +- the taint Value is string now, it is theoretically possible that several errors are detected for one PV, we may extend the string to cover this situation: combine the errors together and splited by semicolon or other symbols. + +This was initially brought up to address the external data populator use case, but there were lots of concerns about this proposal. We do not want our main proposal to depend on something that is not approved. + +#### Optional HTTP(RPC) service + +Create a HTTP(RPC) service to receive volume health condition reports from other components. + +Users can extend the volume health condition monitoring by setting up their own detector and report the result to the service. + +This optional service is out of scope for this KEP but may be introduced in a future KEP if needed. + +This option is not in the main proposal because it is a push-based method while CSI uses pull-based method. + +## Graduation Criteria +### Alpha -> Beta +* Feature complete, including: + * External controller volume health monitoring. + * External node agent volume health monitoring. +* Tests outlined in design proposal implemented. + +### Beta -> GA +* Volume health support is added to multiple CSI drivers. +* Volume health feature deployed in production and have gone through at least one K8s upgrade. + +## Test Plan +### Unit tests +* Unit tests for external controller and external node agent volume health monitoring. The following error codes will be simulated in the unit tests: + * VolumeNotFound + * OutOfCapacity + * VolumeUnmounted + * NodeDown + +### E2E tests +* e2e tests for external controller and external node agent volume health monitoring. Hostpath CSI driver and GCE PD driver will be used for e2e tests. The following error codes will be tested in the e2e tests: + * VolumeNotFound + * OutOfCapacity + * VolumeUnmounted +* Add stress and scale tests before moving from beta to GA. + +## Implementation History + +- 20191021: KEP updated + +- 20190730: KEP updated + +- 20190530: KEP submitted + +- Demo implementation (using annotations): +https://github.com/NickrenREN/kubemonitor/tree/master/build/kube_storage_monitor/local_monitor +https://github.com/NickrenREN/kubemonitor/tree/master/build/kube_storage_monitor/node_watcher