Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename the kubeadm master node-role label and taint #2067

Closed
neolit123 opened this issue Oct 3, 2020 · 43 comments
Closed

rename the kubeadm master node-role label and taint #2067

neolit123 opened this issue Oct 3, 2020 · 43 comments
Labels
kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle.

Comments

@neolit123
Copy link
Member

neolit123 commented Oct 3, 2020 •
edited by kikisdeliveryservice
Loading

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Oct 3, 2020
@neolit123
Copy link
Member Author

/milestone v1.20
/sig cluster-lifecycle

@k8s-ci-robot k8s-ci-robot added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Oct 3, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Oct 3, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Oct 3, 2020
@neolit123 neolit123 added the kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. label Oct 3, 2020
@neolit123 neolit123 mentioned this issue Oct 3, 2020
Merged
@neolit123
Copy link
Member Author

created the KEP PR here:
#2068

the plan for 1.20 is agreed on, so we can merge this as "implementable" on Tuesday next week and amend for other stages later.

@neolit123 neolit123 mentioned this issue Oct 3, 2020
Closed
19 tasks
@kikisdeliveryservice kikisdeliveryservice added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Oct 5, 2020
@kikisdeliveryservice
Copy link
Member

hi @neolit123 !

as a reminder your PR (#2068 ) needs to merge by EOD PST tomorrow October 6th to be included in the 1.20 Release. After that time you will need to request an exception.

@kikisdeliveryservice kikisdeliveryservice changed the title rename the kubeadm "master" node-role label and taint rename the kubeadm master node-role label and taint Oct 5, 2020
@kikisdeliveryservice
Copy link
Member

(note: i had to remove the quotes around master in the title of this issue as they broke our spreadsheet tooling)

@neolit123
Copy link
Member Author

@kikisdeliveryservice #2068 merged.

@kikisdeliveryservice
Copy link
Member

Thanks for the update @neolit123 ! I updated in the tracking sheet 👍

@neolit123 neolit123 mentioned this issue Oct 6, 2020
Merged
@eagleusb
Copy link

Hello @neolit123 👋, 1.20 Docs shadow here.

Does this enhancement work planned for 1.20 require any new docs or modification to existing docs?
If so, please follows the steps here to open a PR against dev-1.20 branch in the k/website repo.

This PR can be just a placeholder at this time and must be created before Nov 6th

Also take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

@cbron cbron mentioned this issue Oct 28, 2020
Merged
@eagleusb
Copy link

eagleusb commented Nov 2, 2020

Hi @neolit123 👋

The docs placeholder deadline is almost here.

Please make sure to create a placeholder PR against the dev-1.20 branch in the k/website before the deadline.

Also, please keep in mind the important upcoming dates:

As a reminder, please link all of your k/k PR as well as docs PR to this issue for the release team to track.

Thanks !

@neolit123 neolit123 mentioned this issue Nov 5, 2020
Merged
@neolit123
Copy link
Member Author

docs placeholder PR:
kubernetes/website#24907

@kikisdeliveryservice
Copy link
Member

Hey @neolit123 !

I see that kubernetes/kubernetes#95382 is still open.

Just a reminder that Code Freeze is coming up in 2 days on Thursday, November 12th. All PRs must be merged by that date, otherwise an Exception is required.

Thanks!
Kirsten

@neolit123
Copy link
Member Author

@kikisdeliveryservice noted, thanks.

@kikisdeliveryservice
Copy link
Member

Looks like that PR has merged. Excellent! 👍

@neolit123
Copy link
Member Author

docs placeholder PR:
kubernetes/website#24907

note, we dropped the idea to add mentions about this change in the docs for 1.20
kubernetes/website#24907 is now a placeholder for something else.

@kikisdeliveryservice
Copy link
Member

Gotcha - thanks!

cc: @annajung

@annajung annajung removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jan 7, 2021
@annajung
Copy link
Contributor

annajung commented Jan 7, 2021

Hi @neolit123 1.21 Enhancement Lead here.

I believe this issue can close now. Before closing, can you update the kep.yaml to reflect a status of implemented:

enhancements/keps/sig-cluster-lifecycle/kubeadm/2067-rename-master-label-taint/kep.yaml

Line 8 in 35069fd

status: implementable

Once that merges, we can close out this issue.

@neolit123
Copy link
Member Author

hi @annajung we need to keep this open until around 1.24+. this is mentioned in the OP here and the KEP.

@annajung annajung removed this from the v1.20 milestone Jan 7, 2021
@rhockenbury
Copy link

From the Slack thread, it feels like there is general agreement with not requiring a PRR for kubeadm. I'll mark this as tracked for enhancement freeze.

@jiahuif
Copy link
Member

jiahuif commented Jan 28, 2022

Hello @neolit123 👋, 1.24 Enhancements team here.
Just checking in as we approach enhancements freeze on 18:00pm PT on Thursday Feb 3rd, 2022.

This enhancement looks great! Thank you for the effort.

@rhockenbury
Copy link

rhockenbury commented Jan 31, 2022 •
edited
Loading

Hi @neolit123 - my prior comment is a miscommunication. The comment here from the PRR team summarizes the expectations. Let me know if you plan to update to include the PRR reviewer, or if you would like to remove this KEP from the 1.24 milestone.

@neolit123
Copy link
Member Author

hi, i have removed this KEP from the enhancement tracking sheet:
https://docs.google.com/spreadsheets/d/1T21mUTvPh70NB2eseHjCyD4LgRjyxWI9Bd1SoP8zAwA/edit#gid=1954476102
please remove the label "tracked/yes" and the milestone 1.24 from this ticket.
thank you.

@gracenng gracenng removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Feb 1, 2022
@gracenng gracenng removed this from the v1.24 milestone Feb 1, 2022
@Nick-Triller Nick-Triller mentioned this issue Feb 28, 2022
Merged
3 tasks
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 2, 2022
@neolit123
Copy link
Member Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 2, 2022
@neolit123 neolit123 mentioned this issue May 17, 2022
Merged
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 31, 2022
@neolit123
Copy link
Member Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 31, 2022
@neolit123 neolit123 mentioned this issue Aug 25, 2022
Merged
@t106362512 t106362512 mentioned this issue Oct 27, 2022
Closed
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 29, 2022
@neolit123 neolit123 removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 29, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 27, 2023
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 26, 2023
@neolit123 neolit123 removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Feb 26, 2023
@neolit123
Copy link
Member Author

closing as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
10 participants
@neolit123 @jiahuif @rhockenbury @kikisdeliveryservice @eagleusb @k8s-ci-robot @annajung @fejta-bot @gracenng @k8s-triage-robot