Skip to content

Commit

Permalink
node: podresources: clarify GA blockers
Browse files Browse the repository at this point in the history
Clarify GA blockers as asked in
#3791 (review)
#3791 (comment)

- Explicitely added windows support (and all the other platforms supported by
  device plugins) as GA condition.
- Added DOS prevention as GA condition, and clarified the perimeter of
  the DOS attack surface area.

Signed-off-by: Francesco Romani <[email protected]>
  • Loading branch information
ffromani committed Feb 9, 2023
1 parent c80f656 commit d3d2360
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion keps/sig-node/606-compute-device-assignment/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,8 @@ covered by e2e tests
- [X] Multiple real world examples ([Multus CNI](https://github.com/intel/multus-cni)).
- [X] Allowing time for feedback (2 years).
- [X] [Start Deprecation of Accelerator metrics in kubelet](https://github.com/kubernetes/kubernetes/pull/91930).
- [X] The API endpoint should be available on all the platforms kubelet runs and supports device plugins (linux, windows, ...).
- [X] Rate limiting mechanisms are implemented in the server to prevent excessive load from malfunctioning/rogue clients.
- [X] Risks have been addressed.

### Upgrade / Downgrade Strategy
Expand Down Expand Up @@ -323,7 +325,9 @@ No. Feature is out of existing any paths in kubelet.

###### Will enabling / using this feature result in non-negligible increase of resource usage (CPU, RAM, disk, IO, ...) in any components?

In 1.18, DDOSing the API can lead to resource exhaustion. It is planned to be addressed as part of G.A.
In 1.18, DOSing the API can lead to resource exhaustion. It is planned to be addressed as part of G.A.
The API is exposed only through a unix-domain socket local to the node, so malicious agents can only be among pods running on the same node (e.g.
no network access) which have been granted permission to access the unix domain socket with volume mounts and filesystem permissions.
Feature only collects data when requests comes in, data is then garbage collected. Data collected is proportional to the number of pods on the node.

###### Can enabling / using this feature result in resource exhaustion of some node resources (PIDs, sockets, inodes, etc.)?
Expand Down

0 comments on commit d3d2360

Please sign in to comment.