diff --git a/keps/sig-auth/3325-self-subject-attributes-review-api/README.md b/keps/sig-auth/3325-self-subject-attributes-review-api/README.md index a9e0b303eda..7b347110e7b 100644 --- a/keps/sig-auth/3325-self-subject-attributes-review-api/README.md +++ b/keps/sig-auth/3325-self-subject-attributes-review-api/README.md @@ -11,6 +11,10 @@ - [Request](#request) - [RBAC](#rbac) - [Test Plan](#test-plan) + - [Prerequisite testing updates](#prerequisite-testing-updates) + - [Unit tests](#unit-tests) + - [Integration tests](#integration-tests) + - [e2e tests](#e2e-tests) - [Graduation Criteria](#graduation-criteria) - [Alpha](#alpha) - [Beta](#beta) @@ -175,21 +179,76 @@ If necessary, it will be possible to disable this API by using the following kub ### Test Plan -Unit tests covering: +[X] I/we understand the owners of the involved components may require updates to +existing tests to make this code solid enough prior to committing the changes necessary +to implement this enhancement. + +##### Prerequisite testing updates + + + +N/A + +##### Unit tests + + + + + +The plan to test the SelfSubjectAttributesReview API is: 1. Request returns all user attributes 2. Request returns some user attributes 3. Request with a status returns overridden fields -Integration tests covering: +Command line interface tests covering: +1. How successful responses are rendered in the terminal with various output modes. +2. How errors are rendered. + +Given that a new API package is introduced as part of this feature there is +no existing test coverage to link to. + +##### Integration tests + + 1. Successful authentication through a simple authenticator, e.g., token or certificate authenticator 2. Successful authentication through a complicated authenticator, e.g., webhook or authentication proxy authenticator 3. Failed authentication -Command line interface tests covering: -1. How successful responses are rendered in the terminal with various output modes. -2. How errors are rendered. +##### e2e tests + + + +There are no e2e tests planned for the alpha milestone. ### Graduation Criteria