From 54911edbc72dd32c040873f5bd3d4ada6631df1d Mon Sep 17 00:00:00 2001 From: Byonggon Chun Date: Mon, 5 Aug 2019 23:07:58 +0900 Subject: [PATCH] fix typo Signed-off-by: Byonggon Chun --- keps/sig-node/20190129-hugepages.md | 17 +++++------------ 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/keps/sig-node/20190129-hugepages.md b/keps/sig-node/20190129-hugepages.md index 0d33948d51df..4d2aca6e0721 100644 --- a/keps/sig-node/20190129-hugepages.md +++ b/keps/sig-node/20190129-hugepages.md @@ -43,7 +43,7 @@ superseded-by: - [cAdvisor changes(Phase 1)](#cadvisor-changes(Phase-1)) - [Phase 2](#Phase-2) - [Support container isolation of huge pages](#support-container-isolation-of-huge-pages) - - [Support reserve huge pages for system on Node Allocatable feature](#support-reserve-huge-pages-for-system-on-node-allocatable-feature) + - [Enhance Node Allocatable feature to reserve huge pages for system](#enhance-node-allocatable-feature-to-reserve-huge-pages-for-system) - [cAdviser changes(Phase 2)](#cAdviser-changes(Phase-2)) - [Phase 3](#Phase-3) - [Update LinuxContainerResources(CRI) to support specifying huge page limits](#update-linuxcontainerresources(cri)-to-support-specifying-huge-page-limits) @@ -335,20 +335,13 @@ calculate allocatable values on the node. #### Support container isolation of huge pages -Container isolation of huge pages should be supported to avoid competition between containers to consume huge pages. Currently, `kubelet` sets the agregated huge pages limits on pod's cgroup of hugetlb subsystem. This should be enhanced to set limits on container's cgroup. +Container isolation of huge pages should be supported to avoid competition between containers to consume huge pages. Currently, `kubelet` directly sets the aggregated huge pages limits on pod's cgroup of hugetlb subsystem. The limits should be set on a container's cgroup. To achieve this, the `LinuxContainerResources` message which is used to update the container resource should be updated to specify huge page limits per container. `containerd` also should be updated to handle huge page. #### cAdviser changes(Phase 2) -To support NUMA, `cAdviser` should collect and store pre-allocated huge pages per NUMA node. +To support NUMA, `cAdviser` should discover and store pre-allocated huge pages per NUMA node. The `v3` version of `MachineInfo` will be introduced. - -#### Support reserve huge pages for system on Node Allocatable feature -Some system services like `OVS-DPDK` comsume huge pages per NUMA node, to determine allocatalbe number of huge pages in `kubelet`, `Node Allocatable feature` should support to reserve huge pages per NUMA node. - -### Phase 3 - -##### Update LinuxContainerResources(CRI) to support specifying huge page limits - -To set huge page limits through systemd by using CRI, `LinuxContainerResources` message should be updated to specify huge page limits. `systemd` also should be updated to handle huge page. +#### Enhance Node Allocatable feature to reserve huge pages for system +Some system services like `OVS-DPDK` comsume huge pages per NUMA node, to determine the allocatalbe number of huge pages in `kubelet`, `Node Allocatable feature` should support to reserve huge pages per NUMA node. ### Risks and Mitigations