From 65f20b9860fb86e09a336876bd28a2780df6198d Mon Sep 17 00:00:00 2001 From: danielqsj Date: Mon, 28 Jan 2019 15:10:12 +0800 Subject: [PATCH] Add deprecation plan and new PRs for kep --- .../0031-kubernetes-metrics-overhaul.md | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/keps/sig-instrumentation/0031-kubernetes-metrics-overhaul.md b/keps/sig-instrumentation/0031-kubernetes-metrics-overhaul.md index 52285a413fc..aa9926e6637 100644 --- a/keps/sig-instrumentation/0031-kubernetes-metrics-overhaul.md +++ b/keps/sig-instrumentation/0031-kubernetes-metrics-overhaul.md @@ -38,9 +38,12 @@ status: implementable * [Kube-scheduler metric changes](#kube-scheduler-metric-changes) * [Kube-proxy metric changes](#kube-proxy-metric-changes) * [Kube-apiserver metric changes](#kube-apiserver-metric-changes) + * [Apiserver and etcd metrics](#apiserver-and-etcd-metrics) + * [Fix admission metrics in true units](#fix-admission-metrics-in-true-units) * [Client-go metric changes](#client-go-metric-changes) * [Workqueue metrics](#workqueue-metrics) * [Risks and Mitigations](#risks-and-mitigations) +* [Deprecation Plan](#deprecation-plan) * [Graduation Criteria](#graduation-criteria) * [Implementation History](#implementation-history) @@ -119,8 +122,14 @@ https://github.com/kubernetes/kubernetes/pull/72334 ### Kube-apiserver metric changes +#### Apiserver and etcd metrics + https://github.com/kubernetes/kubernetes/pull/72336 +#### Fix admission metrics in true units + +https://github.com/kubernetes/kubernetes/pull/72343 + ### Client-go metric changes #### Workqueue metrics @@ -139,6 +148,14 @@ Risks include users upgrading Kubernetes, but not updating their usage of Kubern To prevent this, we will implement recording rules for Prometheus that allow best effort backward compatibility as well as update uses of breaking metric usages in the [Kubernetes monitoring mixin](https://github.com/kubernetes-monitoring/kubernetes-mixin), a widely used collection of Prometheus alerts and Grafana dashboards for Kubernetes. +## Deprecation Plan + +In our efforts to change existing old metrics, we flag them `(Deprecated)` in the front of metrics help text. + +These old metrics will be deprecated in v1.14 and coexist with the new replacement metrics. Users can use this release to change related monitoring rules and dashboards. + +The release target of removing the deprecated metrics is v1.15. + ## Graduation Criteria All metrics exposed by components from kubernetes/kubernetes follow Prometheus best practices and (nice to have) tooling is built and enabled in CI to prevent simple violations of said best practices.