From 09a41a1491f17687ac28d2b5c0a1c8d7ef0de1d4 Mon Sep 17 00:00:00 2001 From: Maciej Szulik Date: Tue, 1 Feb 2022 18:29:01 +0100 Subject: [PATCH] Added metric --- .../3140-TimeZone-support-in-CronJob/README.md | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/keps/sig-apps/3140-TimeZone-support-in-CronJob/README.md b/keps/sig-apps/3140-TimeZone-support-in-CronJob/README.md index bcfbf8b5cf0..a779c163303 100644 --- a/keps/sig-apps/3140-TimeZone-support-in-CronJob/README.md +++ b/keps/sig-apps/3140-TimeZone-support-in-CronJob/README.md @@ -232,6 +232,9 @@ there are a few cases: should be no change in behavior. 3. If TimeZone feature gate was not enabled there should be no change in behavior. +Irrespectively of the option, cluster administrator should monitor `cronjob_job_creation_skew` +which reports the skew between schedule and actual job creation. + ### Version Skew Strategy This feature has no node runtime implications. @@ -286,6 +289,10 @@ rollout. Similarly, consider large clusters and how enablement/disablement will rollout across nodes. --> +An upgrade flow can be vulnerable to the enable, disable, enable if you have +a lease that is acquired by a new kube-controller-manager, then an old +kube-controller-manager, then a new kube-controller-manager. + ###### What specific metrics should inform a rollback? -- [ ] Metrics - - Metric name: - - [Optional] Aggregation method: - - Components exposing the metric: +- [x] Metrics + - Metric name: `cronjob_controller_rate_limiter_use` + - Components exposing the metric: `kube-controller-manager` - [ ] Other (treat as last resort) - Details: