Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(common): when init container restartPolicy is always, think as sidecar #9354

Closed
wants to merge 1 commit into from
Closed

fix(common): when init container restartPolicy is always, think as sidecar #9354

wants to merge 1 commit into from

Conversation

linghaoSu
Copy link

@linghaoSu linghaoSu commented Aug 13, 2024 •
edited
Loading

fix #9299

Context

According to the documentation, when the restartPolicy of an initContainer is set to Always, it is considered a sidecar container. Therefore, these containers should be considered as running normally (i.e., not in the initialization state) as long as they are not in the Terminated state.

Solution Proposed

Add a check for the restartPolicy in the initContainer spec and whether the current initContainer is in the State.Terminated.

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Aug 13, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: linghaoSu / name: Linghao Su (6a22424)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Aug 13, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @linghaoSu!

It looks like this is your first PR to kubernetes/dashboard 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/dashboard has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: linghaoSu
Once this PR has been reviewed and has the lgtm label, please assign shu-mutou for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 13, 2024
@floreks floreks mentioned this pull request Sep 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maciaszczykm maciaszczykm Awaiting requested review from maciaszczykm

@shu-mutou shu-mutou Awaiting requested review from shu-mutou

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dashboard pod status not reported correctly for pods using native sidecar containers
2 participants
@linghaoSu @k8s-ci-robot