Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom ordering for replicasets #882

Open
therc opened this issue Jun 13, 2016 · 6 comments
Open

Custom ordering for replicasets #882

therc opened this issue Jun 13, 2016 · 6 comments
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done.

Comments

@therc
Copy link
Member

therc commented Jun 13, 2016

Copying from a comment in issue 817, #817 (comment)

I think replica sets need custom ordering, because of the way they are created and managed by deployments.

To give you an example, assume that I have three deployments, A, B and C, that I learned the lesson and that I set revisionHistoryLimit to 3. This means I'll eventually have four replica sets for each (current rollout, plus history of three).

The rollouts happen with different schedules. For convenience, let's refer to the replica sets with {DEPLOYMENT}{AGE_IN_DAYS}. So I have A0, A7, A14, A21, B9, B19, B29, B39, C1, C3, C5, C7.
The only ones to have any running pods are A0, B9, C1, unless there's a rolling update in progress. So the best ordering might be those three (sorted by date, preferably, so that during an update the 'fresh' replica set shows first, or otherwise name), followed by all the other empty replica sets. If I merely sorted by age, I would have useless replicasets like C3, C5, C7 and A7 showing up before B9. Even worse if I sorted by name. The inconvenience only gets worse when the number of deployments or the history size are large (I have 10 for the latter). Or when users don't set any history limits at all.

I would make the case that the empty replica sets should actually be ghosted, show fewer details and/or be hidden by default. Also, like Borg, it would be nice to highlight a RS or RC that is undergoing updates.

@bryk
Copy link
Contributor

bryk commented Jun 13, 2016

Linking CLI issue: kubernetes/kubernetes#27212

@floreks floreks added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/P3 labels Nov 22, 2017
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 20, 2018
@maciaszczykm maciaszczykm added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Feb 27, 2018
@maciaszczykm maciaszczykm removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 28, 2018
@maciaszczykm maciaszczykm added priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. and removed priority/P3 labels Nov 9, 2018
@maciaszczykm
Copy link
Member

Being able to sort by active/desired replicas would be a good thing here. I think then we could close.

@ShivamTyagi12345
Copy link
Member

Can i help with this good first issue . I am a beginner to this Project and am looking to get started'

@avinashupadhya99
Copy link
Contributor

/assign

@ShivamTyagi12345
Copy link
Member

ShivamTyagi12345 commented Oct 30, 2021

Can i help with this good first issue . I am a beginner to this Project and am looking to get started'

/assign

/assign

I am working on this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done.
Projects
None yet
Development

No branches or pull requests

8 participants