Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Services could link to the api service proxy #1181

Closed
colemickens opened this issue Aug 31, 2016 · 10 comments
Closed

Services could link to the api service proxy #1181

colemickens opened this issue Aug 31, 2016 · 10 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@colemickens
Copy link
Contributor

Dashboard version: 1.4.0-beta1
Kubernetes version: 1.4.0-alpha.3
Operating system: ubuntu
Node.js version: n/a
Go version: n/a

Just a nice to have feature req:

screen shot 2016-08-31 at 4 15 35 pm

It would be nice if dashboard could detect that I'm accessing it through the service proxy and then offer to make these internal endpoints hyperlinks as well.

@bryk
Copy link
Contributor

bryk commented Sep 1, 2016

That's good suggestion. We though about it in the past, but then realized that it is hard to detect whether you're running behind the proxy. Will take a closer look at this after our next release.

@bryk bryk added priority/P2 kind/feature Categorizes issue or PR as related to a new feature. labels Sep 13, 2016
@maciaszczykm
Copy link
Member

Another potential issue here is, that proxy might not allow enter all of the services. Number of them can be filtered or inaccessible through proxy. We'll have to investigate it deeper to find out if it's possible to implement.

@colemickens
Copy link
Contributor Author

"filtered" or "inaccessible" ?

The only thing I can think of is cases where the user running kubectl proxy has limited RBAC roles.

(This brings up the point that the dashboard is basically bypassing RBAC in many cases).

@maciaszczykm
Copy link
Member

maciaszczykm commented Nov 10, 2016

@colemickens In my understanding, in case of kubectl proxy --api-prefix=/api/v1/proxy/namespaces/kube-system/services/kubernetes-dashboard usage, only http://localhost:8001/api/v1/proxy/namespaces/kube-system/services/kubernetes-dashboard will be served.

@colemickens
Copy link
Contributor Author

Oh thanks for explaining, I didn't know that!

@maciaszczykm
Copy link
Member

maciaszczykm commented Nov 10, 2016

No problem. It's not so clearly described in kubectl proxy --help.

@cheld
Copy link
Contributor

cheld commented Oct 20, 2017

Relates to
#2249

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 18, 2018
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 17, 2018
@maciaszczykm maciaszczykm added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Feb 27, 2018
@maciaszczykm maciaszczykm removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/P2 labels Nov 9, 2018
@maciaszczykm
Copy link
Member

As it was already said it is hard to detect if the proxy is used and if given service is available. I will close it until we will find a good solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests

6 participants