Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] updating method to ingest external content #223

Closed
wants to merge 16 commits into from
Closed

[WIP] updating method to ingest external content #223

wants to merge 16 commits into from

Conversation

RinkiyaKeDad
Copy link
Member

Signed-off-by: RinkiyaKeDad [email protected]

Fixes #93

Signed-off-by: RinkiyaKeDad <[email protected]>
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 14, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @RinkiyaKeDad!

It looks like this is your first PR to kubernetes/contributor-site 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/contributor-site has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: RinkiyaKeDad
To complete the pull request process, please assign parispittman after the PR has been reviewed.
You can assign the PR to them by writing /assign @parispittman in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 14, 2021
Signed-off-by: RinkiyaKeDad <[email protected]>
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 22, 2021
Signed-off-by: RinkiyaKeDad <[email protected]>
Signed-off-by: RinkiyaKeDad <[email protected]>
Signed-off-by: RinkiyaKeDad <[email protected]>
Signed-off-by: RinkiyaKeDad <[email protected]>
Signed-off-by: RinkiyaKeDad <[email protected]>
Signed-off-by: RinkiyaKeDad <[email protected]>
Signed-off-by: RinkiyaKeDad <[email protected]>
Signed-off-by: RinkiyaKeDad <[email protected]>
Signed-off-by: RinkiyaKeDad <[email protected]>
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 25, 2021
@CIPHERTron
Copy link
Member

Heyy @RinkiyaKeDad is there still any interest to get this PR in?

PS: the last commit message is funny 😸

@RinkiyaKeDad
Copy link
Member Author

Hey @CIPHERTron! I was working on this a few months ago but was having a hard time figuring out the implementation details. I currently don't have the bandwidth to take this on, so I'll close this PR. Thanks for the nudge! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update method in which external content is ingested.
3 participants