This repository has been archived by the owner on Apr 17, 2019. It is now read-only.
[nginx-ingress-controller]: Adapt nginx hash sizes to the number of ingress #1596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aledbf
changed the title
aledbf
changed the title
| @@ -64,6 +64,27 @@ func (ngx *Manager) loadTemplate() error { | |||
| } | |||
|
|
|||
| func (ngx *Manager) writeCfg(cfg config.Configuration, ingressCfg IngressConfig) (bool, error) { | |||
| var longestName int | |||
| var serverNames int | |||
| for _, srv := range ingressCfg.Servers { | |||
There was a problem hiding this comment.
what's the tradeoff in being so precise vs just defaulting it to something high, documenting the limit, and not writing this code?
There was a problem hiding this comment.
what's the tradeoff in being so precise
Using a small value means nginx cannot start or be restarted. This is an example of the error:
[emerg] 17617#0: could not build the server_names_hash, you should increase server_names_hash_bucket_size: 32
just defaulting it to something high
This depends on the amount of hostnames and FQDN length
There was a problem hiding this comment.
yeah i mean just start off with it set to 16384, what do we lose?
There was a problem hiding this comment.
what do we lose?
Nothing, but for instance I need at least 48K :)
|
@aledbf PR needs rebase |
k8s-github-robot
added
the
needs-rebase
aledbf
force-pushed
the
improve-defaults
branch
from
e69033c
to
760562f
Compare
k8s-github-robot
removed
the
needs-rebase
|
@bprashanth ping |
|
LGTM |
|
Automatic merge from submit-queue |
aledbf
pushed a commit
to aledbf/contrib
that referenced
this pull request
Nov 10, 2016
Automatic merge from submit-queue [nginx-ingress-controller]: Adapt nginx hash sizes to the number of ingress This change allows the tuning of 2 important NGINX variables: - server_names_hash_max_size - server_names_hash_bucket_size The default values should be enough for most of the users but after +300 Ingress rules or long hostnames as FQDN NGINX requires tuning of this values or it will not start. The introduced change allows the self-tuning using the Ingress information Using `--v=3` it's possible to see the changes: ``` ... I0822 21:42:10.517778 1 template.go:84] adjusting ServerNameHashMaxSize variable from 4096 to 16384 ... ``` fixes kubernetes-retired#1487
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows the tuning of 2 important NGINX variables:
The default values should be enough for most of the users but after +300 Ingress rules or long hostnames as FQDN NGINX requires tuning of this values or it will not start.
The introduced change allows the self-tuning using the Ingress information
Using
--v=3it's possible to see the changes:fixes #1487
This change is