Skip to content
This repository has been archived by the owner on Apr 17, 2019. It is now read-only.

ingress: use POD_NAMESPACE as a namespace in cli parameters #1571

Merged
merged 2 commits into from
Aug 26, 2016
Merged

ingress: use POD_NAMESPACE as a namespace in cli parameters #1571

merged 2 commits into from
Aug 26, 2016

Conversation

kayrus
Copy link
Contributor

@kayrus kayrus commented Aug 19, 2016 •
edited by thockin
Loading

When you deploy ingress not into default namespace, ingress RC fails with the no service with name default/default-http-backend found: services "default-http-backend" not found error message.

This fix uses POD_NAMESPACE which we already pass into the pod ENV.

This change is Reviewable

@bprashanth
Copy link

makes sense to me, will wait for Manuel to lgtm

@aledbf
Copy link
Contributor

aledbf commented Aug 21, 2016

@kayrus just a comment: in all the examples the default backend service is created in the default namespace (default-backend.yaml). Is up to the user to specify the correct service.
From the docs: --default-backend-service: Service used to serve a 404 page for the default backend. Takes the form namespace/name. The controller uses the first node port of this Service for the default backend.
If @bprashanth is ok with this change then is lgtm.

@aledbf
Copy link
Contributor

aledbf commented Aug 21, 2016

@kayrus please do not change the content of the ingress/vendor/ directory. The content of that directory is generated by godep.

@kayrus
Copy link
Contributor Author

kayrus commented Aug 22, 2016

@aledbf made this vendor change by script. restored.

as for the default backend, I know that.

@kayrus kayrus force-pushed the kayrus/fix_default_namespace branch from e8380f1 to 6551aec Compare August 22, 2016 07:12
@kayrus kayrus force-pushed the kayrus/fix_default_namespace branch from 6551aec to b2158fc Compare August 23, 2016 08:37
@bprashanth bprashanth added the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2016
@bprashanth
Copy link

LGTM thanks

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 8327855 into kubernetes-retired:master Aug 26, 2016
@aledbf aledbf mentioned this pull request Aug 29, 2016
Merged
k8s-github-robot pushed a commit that referenced this pull request Aug 29, 2016
Merge pull request #1653 from aledbf/update-nginx-port
1763c0b 
Automatic merge from submit-queue

[nginx-ingress-controller] Update image version

fixes #1652

#1571 introduced the error because it was merged after the `0.8.3` release
aledbf pushed a commit to aledbf/contrib that referenced this pull request Nov 10, 2016
Merge pull request kubernetes-retired#1571 from marketlogicsoftware/k…
c6a1b82 
…ayrus/fix_default_namespace

Automatic merge from submit-queue

ingress: use POD_NAMESPACE as a namespace in cli parameters

When you deploy ingress not into `default` namespace, ingress RC fails with the `no service with name default/default-http-backend found: services "default-http-backend" not found` error message.

This fix uses `POD_NAMESPACE` which we already pass into the pod ENV.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kayrus @bprashanth @aledbf @k8s-github-robot @googlebot