Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We should notify the user to pass the GOROOT env when invoking the client-gen #178

Open
spacewander opened this issue Aug 19, 2024 · 1 comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@spacewander
Copy link

We have noticed the client-gen failed to run sometimes in GitHub Action. After the investigation in mosn/htnn#687, we found that the GOROOT mismatching causes it.

The client-gen imports gengo, and gengo imports go/build. The go/build module will invoke the go toolchain to generate the go code. If the GOROOT is not given as the env var, go/build will use the builtin default GOROOT to look up the go toolchain.

This brings a problem when the client-gen is built with a go compiler A and then executed on a machine that has a go compiler B, the builtin GOROOT is different from the real GOROOT, causes fork/exec xxx/go: no such file or directory error.

To avoid such an error, we should notify the user to pass the GOROOT env when invoking the client-gen, so the environment to build client-gen doesn't impact the environment to use client-gen. For example, GOROOT=$(go env GOROOT) client-gen ....

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

3 participants