Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[occm] Shared loadbalancer should not be renamed. #2682

Open
kratisto opened this issue Oct 1, 2024 · 0 comments
Open

[occm] Shared loadbalancer should not be renamed. #2682

kratisto opened this issue Oct 1, 2024 · 0 comments

Comments

@kratisto
Copy link

kratisto commented Oct 1, 2024

Hello,

Is this a BUG REPORT or FEATURE REQUEST?:
/kind bug

While testing shared loadbalancers, i think i discovered a regression since this PR.

A shared loadbalancer is renamed due to this if. What happens here is :

We enter the ensureOctaviaLoadBalancer function as clusterb with a shared loadbalancer named : kube_service_clustera_kns_fakeservice

At the end we can see the cluster has been renamed : kube_service_clusterb_kns_fakeservice.

And we have the event :
Warning LoadBalancerRename Loadbalancer fakeloadbalancerid has a name of kube_service_clustera_kns_fakeservice with incorrect cluster-name component. Renaming it to kube_service_clusterb_kns_fakeservice.

The tags has been changed too :
["kube_service_clustera_kns_fakeservice","clustera","kube_service_clusterb_kns_fakeservice"]
become ["kube_service_clusterb_kns_fakeservice","clustera","kube_service_clusterb_kns_fakeservice"]

I created a test that reproduce the regression.

Didn't test if it's the case , but i suspect that if we launch a third time as clusterc , the shared loadbalancer will be renamed again.
So the ownership will be for the last runner of ensureOctaviaLoadBalancer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant