-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[occm] Support loadbalancer.openstack.org/flavor-name
instead of only loadbalancer.openstack.org/flavor-id
#2600
Comments
I think Octavia allows to have multiple flavors using the same name. We could probably just fail when there is more than one flavor of such a name, but that's increasing the complexity of debugging a bit. Anyway I'm not totally opposed to this. |
Hi @dulek It is indeed possible to have the same flavor although an OpenStack admin creates those, so I would guess that the change of having duplicated is not that high. Failing the creation of the loadbalancer would be a good idea then or to fallback to the default by not setting any of the config (so using not the name as none could be found). |
at least in our openstack, these flavors are not visible for normal users. How to solve this issue? |
Do you currently provide them with an ID? Then a name would make it easier. |
yes, we provide them with id. I do not see how |
Is it possible in your environment to list the loadbalancer flavors (through this endpoint: https://docs.openstack.org/api-ref/load-balancer/v2/#list-flavors), in our environment this is supported. So this would be my best guess to make it work. Using names would make it easier and understandable for the people that are defining the loadbalancer. |
Right, I did not know about that endpoint. Seems to work for me as well. So it should be open for normal openstack users as well. |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
Is this a BUG REPORT or FEATURE REQUEST?:
/kind feature
What happened:
Reading the documentation for the cloud-provider-openstack I found it is possible to specify a loadbalancer flavor by id, although it would be handy and simpeler if it is possible to also create one by using the flavor name (if no flavor-id is specified).
What you expected to happen:
That a loadbalancer flavor is selected based on the name when the annotation
loadbalancer.openstack.org/flavor-name
is usedThe text was updated successfully, but these errors were encountered: