Inconsistency in the field envs for secretGenerator between the CLI and this pkg

[manute]

Hello,

It seems that the latest version of kustomize CLI (3.8.2) requires for the field envs in a secretGenerator a list of the possibles files. And the latest version of this pkg, requires for that field, the property env with a string.

It would be nice if this pkg is aligned with the cli, and I can work on a PR if that's ok.

[nikhita]

cc @seans3

[seans3]

/assign @monopole

[monopole]

The env field was deprecated in May of 2019, and removed in Oct 2019 ( kubernetes-sigs/kustomize#1637 ). It was replaced by envs, since the field is a list (an api fix).
It will be fixed in kubectl when kubernetes-sigs/kustomize#1500 closes.

[manute]

Thanks for the info, I was referrering to the inconsistency running this (with k8s.io/cli-runtime v0.19.0) ->

import "k8s.io/cli-runtime/pkg/kustomize"
..

kustomize.RunKustomizeBuild(...)

Because it's failing for the field envs and only accepts env, and on the other hand the kustomize CLI (3.8.2) it's using the correct field envs.

So I'm not completely sure that the issue you mentioned will fix this.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[monopole]

This will only be fixed (in kubectl) by closing kubernetes-sigs/kustomize#1500 (targetting next release, march 2021)

/close

[k8s-ci-robot]

@monopole: Closing this issue.

In response to this:

This will only be fixed (in kubectl) by closing kubernetes-sigs/kustomize#1500 (targetting next release, march 2021)

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.