Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CA-1.19] Backport #3416 #3557

Merged

Conversation

benmoss
Copy link
Member

@benmoss benmoss commented Sep 29, 2020

Trying to do work on the 1.19 branch, and running into the same problem that #3416 fixes on master.

Replacing the module path in go.mod did not solve
the issue preventing hack/update-vendor.sh from
running properly, so it will have to be deleted.

@detiber @elmiko @tghartland

Replacing the module path in go.mod did not solve
the issue preventing hack/update-vendor.sh from
running properly, so it will have to be deleted.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 29, 2020
@tghartland
Copy link
Contributor

I can't approve the PR myself, but yes this should be backported. Apologies again for breaking update-vendor in the first place.

/lgtm

@k8s-ci-robot
Copy link
Contributor

@tghartland: changing LGTM is restricted to collaborators

In response to this:

I can't approve the PR myself, but yes this should be backported. Apologies again for breaking update-vendor in the first place.

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 30, 2020
@elmiko
Copy link
Contributor

elmiko commented Sep 30, 2020

/lgtm

@benmoss
Copy link
Member Author

benmoss commented Sep 30, 2020

/assign @vivekbagade

@benmoss
Copy link
Member Author

benmoss commented Sep 30, 2020

ugh @feiskyer isn't an approver on 1.19 😸

Copy link
Contributor

@mwielgus mwielgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, mwielgus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2020
@k8s-ci-robot k8s-ci-robot merged commit 550e6ef into kubernetes:cluster-autoscaler-release-1.19 Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants