From ce85be573deea0201018b3e46f3caca70f37c427 Mon Sep 17 00:00:00 2001 From: Denton24646 Date: Mon, 8 Jul 2019 22:44:48 -0400 Subject: [PATCH 1/2] tweak: add CMD arg to Dockerfiles --- vertical-pod-autoscaler/pkg/admission-controller/Dockerfile | 3 ++- vertical-pod-autoscaler/pkg/updater/Dockerfile | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/vertical-pod-autoscaler/pkg/admission-controller/Dockerfile b/vertical-pod-autoscaler/pkg/admission-controller/Dockerfile index 0a07ace3ec91..821d8b846953 100644 --- a/vertical-pod-autoscaler/pkg/admission-controller/Dockerfile +++ b/vertical-pod-autoscaler/pkg/admission-controller/Dockerfile @@ -17,4 +17,5 @@ MAINTAINER Tomasz Kulczynski "tkulczynski@google.com" ADD admission-controller admission-controller -ENTRYPOINT ./admission-controller --v=4 --stderrthreshold=info +ENTRYPOINT ["./admission-controller"] +CMD ["--v=4 --stderrthreshold=info"] diff --git a/vertical-pod-autoscaler/pkg/updater/Dockerfile b/vertical-pod-autoscaler/pkg/updater/Dockerfile index 8f578b88a660..acb01bd0c7df 100644 --- a/vertical-pod-autoscaler/pkg/updater/Dockerfile +++ b/vertical-pod-autoscaler/pkg/updater/Dockerfile @@ -12,10 +12,10 @@ # See the License for the specific language governing permissions and # limitations under the License. - FROM k8s.gcr.io/debian-base-amd64:1.0.0 MAINTAINER Marcin Wielgus "mwielgus@google.com" ADD updater updater -ENTRYPOINT ./updater --v=4 --stderrthreshold=info +ENTRYPOINT ["./updater"] +CMD ["--v=4 --stderrthreshold=info"] From 9e697e8fa50d0b2823c454b479363a6d5c2d32a3 Mon Sep 17 00:00:00 2001 From: Denton24646 Date: Wed, 10 Jul 2019 20:49:21 -0400 Subject: [PATCH 2/2] fix: separate CMD args --- vertical-pod-autoscaler/pkg/admission-controller/Dockerfile | 2 +- vertical-pod-autoscaler/pkg/updater/Dockerfile | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/vertical-pod-autoscaler/pkg/admission-controller/Dockerfile b/vertical-pod-autoscaler/pkg/admission-controller/Dockerfile index 821d8b846953..bec10526d3c2 100644 --- a/vertical-pod-autoscaler/pkg/admission-controller/Dockerfile +++ b/vertical-pod-autoscaler/pkg/admission-controller/Dockerfile @@ -18,4 +18,4 @@ MAINTAINER Tomasz Kulczynski "tkulczynski@google.com" ADD admission-controller admission-controller ENTRYPOINT ["./admission-controller"] -CMD ["--v=4 --stderrthreshold=info"] +CMD ["--v=4", "--stderrthreshold=info"] diff --git a/vertical-pod-autoscaler/pkg/updater/Dockerfile b/vertical-pod-autoscaler/pkg/updater/Dockerfile index acb01bd0c7df..d8a65b921f47 100644 --- a/vertical-pod-autoscaler/pkg/updater/Dockerfile +++ b/vertical-pod-autoscaler/pkg/updater/Dockerfile @@ -18,4 +18,4 @@ MAINTAINER Marcin Wielgus "mwielgus@google.com" ADD updater updater ENTRYPOINT ["./updater"] -CMD ["--v=4 --stderrthreshold=info"] +CMD ["--v=4", "--stderrthreshold=info"]