Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cluster Autoscaler patch releases #3317

Closed
MaciekPytel opened this issue Jul 14, 2020 · 16 comments
Closed

Cluster Autoscaler patch releases #3317

MaciekPytel opened this issue Jul 14, 2020 · 16 comments

Comments

@MaciekPytel
Copy link
Contributor

I'm planning to build a series of Cluster Autoscaler patch releases on Tuesday 2020-07-21. Patch releases will involve bumping kubernetes dependencies to address #3224.
If you have any other bugfix cherry-pick PRs you want included, please leave a comment here.

Tagging all cloudprovider owners for visibility:
cc: @ringtail @Jeffwan @jaypipes @feiskyer @marwanad @nilo19 @hello2mao @frobware @enxebre @elmiko @hardikdr @detiber @ncdc @andrewsykim @MorrisLaw @tghartland @mwielgus @gjtempleton (really sorry if I missed anyone)

@gjtempleton
Copy link
Member

gjtempleton commented Jul 20, 2020

From the AWS side, I think we definitely want to ensure that #3185 is Cherry-picked as far back as possible as a bug fix (@Jeffwan / @jaypipes could you confirm?)

@marwanad
Copy link
Member

Can we get this #3326 merged to master before the 1.19 cut? Tests pass but master is in a broken state.

@MaciekPytel
Copy link
Contributor Author

@gjtempleton @Jeffwan @jaypipes Can you open cherry-picks if you think this is needed? I can wait until tomorrow or Thursday if needed with cutting the release.

@marwanad Merged, sorry for the presubmit issue.

@MaciekPytel
Copy link
Contributor Author

Status update - I've started to do dependency updates required to fix #3224, however, it has proved problematic for 1.17 (apparently go.mod in kubernetes/kubernetes lists the wrong go version, which breaks our vendoring process). There may be some additional delay, as I fix this issue.

@nigelellis
Copy link

nigelellis commented Jul 24, 2020

Can we also please pull in #3124 in 1.17? A cherrypick for 1.16 was already opened as #3248.

Thanks.

@johanneswuerbach
Copy link
Contributor

Could you also pull in #3359? Sadly this isn't easily applicable to 1.17.

@MaciekPytel
Copy link
Contributor Author

@nigelellis @johanneswuerbach Done.

Are there any changes anyone would like to highlight in release notes?
@feiskyer @marwanad - You had a lot of cherry-pick for Azure, do you like to highlight anything?
@frobware @enxebre @elmiko @hardikdr @detiber @ncdc - For Cluster API.
@gjtempleton @Jeffwan - For AWS.

@marwanad
Copy link
Member

@MaciekPytel "bug fixes and improvements" 😆 . I think "Various improvements to scale down scenarios" would capture them all.

@MaciekPytel
Copy link
Contributor Author

@marwanad I was wondering about cherry-picks of #3019. I guess that's just a bugfix on AKS, but I wonder if it won't require updating labels in some self-hosted clusters running on Azure. WDYT?

@marwanad
Copy link
Member

@MaciekPytel So this label comes from AKS-Engine (which is what most people use for self-hosted K8s on Azure) and isn't AKS specific. We should definitely call that out in the release, though.

@MaciekPytel
Copy link
Contributor Author

I released 1.18.2 and 1.17.3. Please let me know if any release notes are missing or need to be corrected and I'll fix it.
I'm planning to do 1.16 release in the next few days, but this is blocked on unittests failing on 1.16 branch. Hopefully it should be fixed in the next few days.

@nigelellis
Copy link

Thank you @MaciekPytel, much appreciated!

@nigelellis
Copy link

I deployed the 1.17.3 release and can confirm that #3124 has fixed my lopsided AWS auto-scaler issues. I now see an even spread of nodes provisioned across SPOT compute ASGs in AWS. Thanks again for the backport and to @joelsmith for the original fix.

@Jeffwan
Copy link
Contributor

Jeffwan commented Aug 4, 2020

Working on other stuffs and have some delay on this. I will double check cherry-pick candidates for 1.16 and below. i will come back asap.

@MaciekPytel
Copy link
Contributor Author

I released 1.16.6 and 1.15.7 and so I'm closing this issue.

If I missed anything important in release notes or you otherwise think they need to be corrected please let me know and I'll update them.

@Jeffwan
Copy link
Contributor

Jeffwan commented Aug 5, 2020

@MaciekPytel Thanks.

Can you help add following sentence to 1.16.6 and 1.17.3 release note?

Solve problem CA does not work with VPC-Endpoint (AWS/EKS) (#2829)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants