Use scale client to Patch the scale subresource when setting the size for a scalableResource

[enxebre]

The capi provider autoscaler mutates scalable resources i.e machineSets by using Update() to change the replica number and add annotations to machines. We should instead rely on the scale subresource and making Patch() requests. This is more idiomatic and reduce the surface impacted by Update() calls and its possible side effects

autoscaler/cluster-autoscaler/cloudprovider/clusterapi/clusterapi_machineset.go

Line 83 in 150bf34

_, updateErr := r.controller.dynamicclient.Resource(*r.controller.machineSetResource).Namespace(u.GetNamespace()).Update(context.TODO(), u, metav1.UpdateOptions{})

/area provider/cluster-api

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[detiber]

This is partially addressed by #3312 (using the scale client), work would still need to be done to use Patch vs Update, though.

/lifecycle frozen