Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let the CAPI group be overridden and discover the preferred version #2932

Closed
enxebre opened this issue Mar 13, 2020 · 5 comments · Fixed by #2934
Closed

Let the CAPI group be overridden and discover the preferred version #2932

enxebre opened this issue Mar 13, 2020 · 5 comments · Fixed by #2934
Assignees
@enxebre
Labels
area/provider/cluster-api Issues or PRs related to Cluster API provider

Comments

@enxebre
Copy link
Member

enxebre commented Mar 13, 2020 •
edited
Loading

We are currently hardcoding the CAPI groups/version supported by the provider https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/cloudprovider/clusterapi/clusterapi_controller.go#L41

We should make the group overridable via env variable and let the version be discovered via discovery client.
@enxebre
Copy link
Member Author

enxebre commented Mar 13, 2020

/assign

@enxebre
Copy link
Member Author

enxebre commented Mar 13, 2020 •
edited
Loading

@MaciekPytel would you please create a label for area/provider/capi? I don't have perms for that.

@enxebre enxebre mentioned this issue Mar 13, 2020
Merged
@enxebre enxebre changed the title Let the CAPI provider discover the preferred version of the CAPI Let the CAPI group be overridden and discover the preferred version Mar 16, 2020
@MaciekPytel
Copy link
Contributor

I created area/provider/cluster-api. Is that ok? I can rename if you prefer, but I think it's more clear compared to capi.

@enxebre
Copy link
Member Author

enxebre commented Mar 16, 2020

thanks @MaciekPytel sgtm. I don't seem to have perms to add a label manually via GH UX. Is there any automation we can use for this? e.g:
/area provider/cluster-api

@k8s-ci-robot k8s-ci-robot added the area/provider/cluster-api Issues or PRs related to Cluster API provider label Mar 16, 2020
@MaciekPytel
Copy link
Contributor

Apparently yes :)
Looking at bot code it seems to just match anything starting with "area/".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@enxebre enxebre

Labels
area/provider/cluster-api Issues or PRs related to Cluster API provider
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes 2932: let the capi version to be discovered enxebre/autoscaler
3 participants
@enxebre @MaciekPytel @k8s-ci-robot