Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VPA - Admission Controller status #2738

Closed
krzysied opened this issue Jan 15, 2020 · 5 comments
Closed

VPA - Admission Controller status #2738

krzysied opened this issue Jan 15, 2020 · 5 comments
Assignees
@krzysied
Labels
area/vertical-pod-autoscaler kind/feature Categorizes issue or PR as related to a new feature.

Comments

@krzysied
Copy link
Contributor

It can potentially happen that Admission Controller is down. When this happens, we don't want to evict pods (recommendation will not be applied).
Admission Controller should have a status object. This status object should be observed by Updater. If status object has not been updated for a long time, Updater should stop evictions.
@krzysied
Copy link
Contributor Author

/assign
/cc @bskiba
/cc @kgolab

@krzysied
Copy link
Contributor Author

krzysied commented Jan 16, 2020 •
edited
Loading

Implementation plan:

Test:

@bskiba bskiba added kind/feature Categorizes issue or PR as related to a new feature. area/vertical-pod-autoscaler labels Jan 17, 2020
This was referenced Jan 17, 2020
Closed
Closed
This was referenced Jan 22, 2020
Merged
Closed
@krzysied krzysied changed the title Vpa - Admission Controller status VPA - Admission Controller status Feb 4, 2020
This was referenced Feb 6, 2020
Merged
Merged
Merged
@krzysied
Copy link
Contributor Author

Tests seem to work https://testgrid.k8s.io/sig-autoscaling-vpa#autoscaling-vpa-updater.
Closing the issue.

@hjkatz
Copy link

hjkatz commented Mar 9, 2020

We were also affected by something similar to #2633 and #2715. Our solution was to restart the admission controller pod and then the recommendation targets seemed to be applied correctly. When will these merged changes be cut into a new release?

@krzysied
Copy link
Contributor Author

@bskiba Do we have any estimation for a new release?

@amshuman-kr amshuman-kr mentioned this issue Aug 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@krzysied krzysied

Labels
area/vertical-pod-autoscaler kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hjkatz @bskiba @krzysied