From a09f4d9c7fb217e765085c52f9fe41bb64decb49 Mon Sep 17 00:00:00 2001
From: Michael Grosser <michael@grosser.it>
Date: Wed, 20 Jul 2022 13:39:01 -0700
Subject: [PATCH] use strings.Join to build list of names

---
 cluster-autoscaler/cloudprovider/resource_limiter.go | 11 ++++-------
 cluster-autoscaler/core/scale_up.go                  | 12 ++++--------
 2 files changed, 8 insertions(+), 15 deletions(-)

diff --git a/cluster-autoscaler/cloudprovider/resource_limiter.go b/cluster-autoscaler/cloudprovider/resource_limiter.go
index 007cfc4d4eb..56143017994 100644
--- a/cluster-autoscaler/cloudprovider/resource_limiter.go
+++ b/cluster-autoscaler/cloudprovider/resource_limiter.go
@@ -17,10 +17,10 @@ limitations under the License.
 package cloudprovider
 
 import (
-	"bytes"
 	"fmt"
 	"k8s.io/apimachinery/pkg/util/sets"
 	"math"
+	"strings"
 )
 
 // ResourceLimiter contains limits (max, min) for resources (cores, memory etc.).
@@ -82,12 +82,9 @@ func (r *ResourceLimiter) HasMaxLimitSet(resourceName string) bool {
 }
 
 func (r *ResourceLimiter) String() string {
-	var buffer bytes.Buffer
+	var resourceDetails = []string{}
 	for _, name := range r.GetResources() {
-		if buffer.Len() > 0 {
-			buffer.WriteString(", ")
-		}
-		buffer.WriteString(fmt.Sprintf("{%s : %d - %d}", name, r.GetMin(name), r.GetMax(name)))
+		resourceDetails = append(resourceDetails, fmt.Sprintf("{%s : %d - %d}", name, r.GetMin(name), r.GetMax(name)))
 	}
-	return buffer.String()
+	return strings.Join(resourceDetails, ", ")
 }
diff --git a/cluster-autoscaler/core/scale_up.go b/cluster-autoscaler/core/scale_up.go
index 74f8c957090..2fd36454a23 100644
--- a/cluster-autoscaler/core/scale_up.go
+++ b/cluster-autoscaler/core/scale_up.go
@@ -17,7 +17,6 @@ limitations under the License.
 package core
 
 import (
-	"bytes"
 	"fmt"
 	"math"
 	"strings"
@@ -575,14 +574,11 @@ func ScaleUp(context *context.AutoscalingContext, processors *ca_processors.Auto
 				}
 			}
 			if len(targetNodeGroups) > 1 {
-				var buffer bytes.Buffer
-				for i, ng := range targetNodeGroups {
-					if i > 0 {
-						buffer.WriteString(", ")
-					}
-					buffer.WriteString(ng.Id())
+				var names = []string{}
+				for _, ng := range targetNodeGroups {
+					names = append(names, ng.Id())
 				}
-				klog.V(1).Infof("Splitting scale-up between %v similar node groups: {%v}", len(targetNodeGroups), buffer.String())
+				klog.V(1).Infof("Splitting scale-up between %v similar node groups: {%v}", len(targetNodeGroups), strings.Join(names, ", "))
 			}
 		}
 		scaleUpInfos, typedErr := processors.NodeGroupSetProcessor.BalanceScaleUpBetweenGroups(