Use RequiresRepublish in secret rotation.

[dargudear-google]

Remove the rotation controller and rely exclusively on RequiresRepublish for secret rotation.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dargudear-google
Once this PR has been reviewed and has the lgtm label, please assign tam7t for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Hi @dargudear-google. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[amitmodak]

Approach broadly LGTM! IIUC, once this PR is submitted, auto-rotation won't work for k8s clusters < 1.21. What is the process to announce and manage this breaking change?

[dargudear-google]

Approach broadly LGTM! IIUC, once this PR is submitted, auto-rotation won't work for k8s clusters < 1.21. What is the process to announce and manage this breaking change?

Discussed in the last community call that we should publish that "For clusters < 1.21, please use v.1.4.5 or earlier."

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 32.14286% with 38 lines in your changes missing coverage. Please review.

Project coverage is 31.01%. Comparing base (87f51ec) to head (7f38830).
Report is 69 commits behind head on main.

Files with missing lines	Patch %	Lines
...rollers/secretproviderclasspodstatus_controller.go	13.79%	24 Missing and 1 partial ⚠️
pkg/secrets-store/secrets-store.go	22.22%	7 Missing ⚠️
pkg/secrets-store/nodeserver.go	75.00%	1 Missing and 2 partials ⚠️
pkg/secrets-store/utils.go	60.00%	1 Missing and 1 partial ⚠️
cmd/secrets-store-csi-driver/main.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1622      +/-   ##
==========================================
- Coverage   35.83%   31.01%   -4.82%     
==========================================
  Files          63       57       -6     
  Lines        3759     3205     -554     
==========================================
- Hits         1347      994     -353     
+ Misses       2268     2108     -160     
+ Partials      144      103      -41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[nilekhc]

/ok-to-test

[nilekhc]

First pass.

In bats tests, where sleep duration/timeout is increased, could you re-evaluate if it's necessary? If yes then could you add a note to make sure we have context?

[dargudear-google]

/retest-required

[dargudear-google]

/retest

[dargudear-google]

/retest

[dargudear-google]

/retest

[k8s-ci-robot]

@dargudear-google: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
release-secrets-store-csi-driver-e2e-azure	50ac633	link	true	/test release-secrets-store-csi-driver-e2e-azure

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[dargudear-google]

/retest

[enj]

/unassign nilekhc
/assign aramase