Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

helm chart separate out toleration for daemonset and crd upgrade hook #1535

Open
sstarcher opened this issue May 29, 2024 · 4 comments · May be fixed by #1538
Open

helm chart separate out toleration for daemonset and crd upgrade hook #1535

sstarcher opened this issue May 29, 2024 · 4 comments · May be fixed by #1538
Assignees
@omerap12
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@sstarcher
Copy link

Describe the solution you'd like
Currently the CRD upgrade hook and the daemonset share the toleration configuration. We have a toleration of Exists specified which allows our daemonsets to continue to run on cordoned nodes, but this causes the CRD upgrade hook to potentially hang.
@sstarcher sstarcher added the kind/feature Categorizes issue or PR as related to a new feature. label May 29, 2024
@omerap12
Copy link
Member

omerap12 commented Jun 1, 2024

I believe I can help with that :)

@omerap12
Copy link
Member

omerap12 commented Jun 1, 2024

/assign

@omerap12 omerap12 linked a pull request Jun 5, 2024 that will close this issue
Open
3 tasks
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 30, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@omerap12 omerap12

Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

separate toleration daemonset and crd upgrade hook omerap12/secrets-store-csi-driver
4 participants
@sstarcher @k8s-ci-robot @k8s-triage-robot @omerap12