Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AhmedGrati as a reviewer #1563

Closed
marquiz opened this issue Jan 25, 2024 · 5 comments · Fixed by #1564
Closed

Add AhmedGrati as a reviewer #1563

marquiz opened this issue Jan 25, 2024 · 5 comments · Fixed by #1564
Assignees
@zvonkok @PiotrProkop @jjacobelli @ArangoGutierrez @adrianchiris @fmuyassarov

Comments

@marquiz
Copy link
Contributor

marquiz commented Jan 25, 2024

I'd like to propose that @AhmedGrati would be added as a project reviewer.

Ahmed has been very active in the project and has contributed a long list of important enhancements and new features, brought up new ideas and also helped in code reviews.

PRs and issues authored:
https://github.com/kubernetes-sigs/node-feature-discovery/pulls?q=author%3AAhmedGrati

Reviews and comments:
https://github.com/kubernetes-sigs/node-feature-discovery/pulls?q=commenter%3AAhmedGrati

I really feel being a bit late and that I should've proposed this earlier 😊
@fmuyassarov
Copy link
Member

Big +1. Thank you @AhmedGrati for all the contributions you have already made.
/lgtm

@PiotrProkop
Copy link
Contributor

Congrats!
/lgtm

@jjacobelli
Copy link
Contributor

Congrats! +1
/lgtm

@AhmedGrati
Copy link

Thank you for the recognition! Happy to join the team 🙏

@marquiz marquiz mentioned this issue Jan 25, 2024
Merged
@marquiz
Copy link
Contributor Author

marquiz commented Jan 25, 2024

Welcome @AhmedGrati 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zvonkok zvonkok

@PiotrProkop PiotrProkop

@jjacobelli jjacobelli

@ArangoGutierrez ArangoGutierrez

@adrianchiris adrianchiris

@fmuyassarov fmuyassarov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

OWNERS: add AhmedGrati as a reviewer marquiz/node-feature-discovery
8 participants
@marquiz @zvonkok @PiotrProkop @jjacobelli @ArangoGutierrez @adrianchiris @fmuyassarov @AhmedGrati