Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't update topologyManagerPolicy and topologyManagerScope attributes of NodeResourceTopology #1254

Closed
PiotrProkop opened this issue Jul 3, 2023 · 4 comments · Fixed by #1256
Closed

Can't update topologyManagerPolicy and topologyManagerScope attributes of NodeResourceTopology #1254

PiotrProkop opened this issue Jul 3, 2023 · 4 comments · Fixed by #1256
Assignees
@PiotrProkop
Labels
kind/bug Categorizes issue or PR as related to a bug.
Milestone
v0.14

Comments

@PiotrProkop
Copy link
Contributor

PiotrProkop commented Jul 3, 2023 •
edited
Loading

What happened:
NFD is only detecting policy and scope of Topology Manager when NRT object doesn't exist. This means that topologyManagerScope and topologyManagerPolicy attributes won't change even if kubelet config was changed to use other TopologyManager policy and scope.

What you expected to happen:

topologyManagerScope and topologyManagerPolicy attributes of NRT objects will be updated when kubelet config was changed.

How to reproduce it (as minimally and precisely as possible):

  • Change TopologyManager policy
  • Restart kubelet
  • NRT object is still advertising old policy
@PiotrProkop PiotrProkop added the kind/bug Categorizes issue or PR as related to a bug. label Jul 3, 2023
@PiotrProkop
Copy link
Contributor Author

/cc @ffromani @Tal-or @swatisehgal

@PiotrProkop PiotrProkop mentioned this issue Jul 3, 2023
Closed
25 tasks
@ffromani
Copy link
Contributor

ffromani commented Jul 3, 2023

it seems a bug indeed. We should update the attributes alongside the zones.

@PiotrProkop
Copy link
Contributor Author

/assign

@marquiz
Copy link
Contributor

marquiz commented Jul 3, 2023

/milestone v0.14

@k8s-ci-robot k8s-ci-robot added this to the v0.14 milestone Jul 3, 2023
@PiotrProkop PiotrProkop mentioned this issue Jul 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PiotrProkop PiotrProkop

Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
v0.14
4 participants
@marquiz @PiotrProkop @k8s-ci-robot @ffromani