Enable NodeFeature API by default

[marquiz]

What would you like to be added:

Set default of -enable-nodefeature-api to true. IOW, will disable the gRPC API (by default) and, instead, use NodeFeature objects for communicating features and labels from nfd-workers to nfd-master. This will also automatically enable the usage of NodeFeature objects for 3rd party extensions.

Why is this needed:

Deprecation of NFD gRPC API.

[marquiz]

Would be nice to get feedback when do you think we're ready to make this switchover 😇 @ArangoGutierrez @zvonkok @mythi @PiotrProkop et al

[PiotrProkop]

I think one thing that is missing to make it happen is to implement leader-election for nfd-master. If someone wants to run multiple replicas of nfd-master we need to prevent multiple pods from updating same CRs :)

[marquiz]

implement leader-election for nfd-master

Good point. Could you create an issue about that?

[PiotrProkop]

implement leader-election for nfd-master

Good point. Could you create an issue about that?

#1188

[marquiz]

@ArangoGutierrez @PiotrProkop what do you think about this one? Wait until v0.15 or push it already in v0.14

[PiotrProkop]

I am fine with both approaches. Leader-election is implemented and if gc PR will be merged we should be good to roll it out.

[marquiz]

Thanks @PiotrProkop. I'm also find with both. Leaving this to @ArangoGutierrez then as he probably has the most experience from the production point-of-view 😊

[ArangoGutierrez]

once this is done, we should set this to true #1305

[ArangoGutierrez]

the API has passed all recent QA tests, so I think is ready for show time!
/assign

[ArangoGutierrez]

/milestone v0.14

[ArangoGutierrez]

WIP