Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add favicon that's related to Kustomize #5312

Open
bugoverdose opened this issue Sep 4, 2023 · 6 comments
Open

Add favicon that's related to Kustomize #5312

bugoverdose opened this issue Sep 4, 2023 · 6 comments
Assignees
@jakezhu9
Labels
kind/documentation Categorizes issue or PR as related to documentation. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@bugoverdose
Copy link
Member

bugoverdose commented Sep 4, 2023 •
edited
Loading

This should be a sub-task of #5290.

Currently we are using default favicons in the docsy submodule, which is not related to Kustomize.

Replace the favicons with something related to kustomize or k8s.

스크린샷 2023-09-04 오후 11 24 48

cc. @annasong20
@k8s-ci-robot k8s-ci-robot added needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 4, 2023
@natasha41575
Copy link
Contributor

/kind documentation
/triage accepted

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 5, 2023
@sarab97
Copy link
Member

sarab97 commented Oct 11, 2023

@natasha41575 i guess this can be closed now. I see favicon is now added.

@natasha41575
Copy link
Contributor

@sarab97 Sorry, I can't seem to find the PR that adds the favicon? If you are looking at kustomize.io, that is the site that we are trying to replace and is unrelated to the site directory that is sitting in this repo.

@loffing
Copy link

loffing commented Dec 21, 2023

/assign

@loffing loffing mentioned this issue Dec 23, 2023
Closed
@loffing
Copy link

loffing commented Feb 8, 2024

/unassign

@jakezhu9
Copy link
Contributor

/assign

@jakezhu9 jakezhu9 mentioned this issue Mar 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jakezhu9 jakezhu9

Labels
kind/documentation Categorizes issue or PR as related to documentation. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Kustomize Documentation
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
6 participants
@natasha41575 @k8s-ci-robot @sarab97 @loffing @bugoverdose @jakezhu9