-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add simple queue control example to python docs #967
add simple queue control example to python docs #967
Conversation
Hi @vsoch. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
FYI @mimowo is looking into #168, which sounds related to what you have been experimenting. Other than that, as discussed offline, we would like to have some CLI (like a kubectl plugin) that would allow users to obtain some basic information about their jobs. I'm hesitant to include too many python scripts as "tutorials" for things that we should provide via built-in mechanisms (either the CLI #487 or a dashboard #940 ) |
Agree!
But perhaps with the include snippets it's not too much? We would only have a simple example, and then one for each operator. I do think this is an important use case for a developer. I needed to figure this out for the snakemake executor that uses kueue. If we have it, developers can easily have a handle to kueue in their workflow tools. If we don't, we add toil that they have to figure it out first. TLDR: getting the information explicitly isn't the goal, which would be satisfied by a plugin or dashboard. The use case is integration into Python based workflow tools (there are a lot). |
Ah, I see where you are coming from. I'll defer to @moficodes to review, with the mindset of keeping the samples as simple as possible |
/ok-to-test |
I think if we move the code sample to samples folder it should be fine. +1 for the kubectl plugin for getting info about kueue. @vsoch happy to pair with you on that. (been looking to explore kubectl plugins). Please rebase and move the example to |
Problem: a developer user might want to (after submission) retrieve and list jobs. Solution: provide a simple example of doing this. Signed-off-by: vsoch <[email protected]>
ad97993
to
45f82f1
Compare
All set! I also removed the hard-coded version from the install script. If someone doesn't provide it, they will install from the main branch. |
I think something is wrong. (Could be my PR that messed it up) We should have For this section https://deploy-preview-967--kubernetes-sigs-kueue.netlify.app/docs/tasks/run_python_jobs/#interact-with-queues-and-jobs is there a |
oh yeah - looks like you switched the labels (or just forgot to change one) - not a problem! I'll fix it here. |
Signed-off-by: vsoch <[email protected]>
After running the example above, you can test the following example to interact | ||
with the results. Write the following to a script called `sample-queue-control.py`. | ||
|
||
{{% include "python/install-kueue-queues.py" "python" %}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be sample-queue-control.py
?
Is there a file called sample-queue-control.py
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep - it got lost in the (now several) rebases but thankfully I had it in another place!
Signed-off-by: vsoch <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: moficodes, vsoch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Problem: a developer user might want to (after submission) retrieve and list jobs.
Solution: provide a simple example of doing this.
What type of PR is this?
/kind documentation
What this PR does / why we need it:
A developer user might want to submit and monitor jobs, and this presents very simple monitoring. However, I'm wondering how this would scale? E.g., would hundreds of users be expected to be on the user-queue, in which case we'd have to (every time) get a complete listing of many jobs and iterate through? Or how would we do something like get jobs associated with a queue (I'm guessing this would be done via the label selector, which I mention at the end, but is that the only way?)
I started on an executor plugin for Snakemake using Kueue this weekend https://github.com/snakemake/snakemake-executor-kueue/ and these questions are real ones that I have :)
Which issue(s) this PR fixes:
The issue is now closed, but my plan is to do the following PRs:
Does this PR introduce a user-facing change?