Introduce feature gates #788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
release-note
k8s-ci-robot
added
the
kind/feature
k8s-ci-robot
added
cncf-cla: yes
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
kerthcet
force-pushed
the
feat/introduce-feature-gates
branch
2 times, most recently
from
f69b9df
to
dbe5a18
Compare
tenzen-y
reviewed
May 22, 2023
| opts := zap.Options{ | ||
| TimeEncoder: zapcore.RFC3339NanoTimeEncoder, | ||
| ZapOpts: []zaplog.Option{zaplog.AddCaller()}, | ||
| } | ||
| opts.BindFlags(flag.CommandLine) | ||
| flag.Parse() | ||
|
|
||
| if err := utilfeature.DefaultMutableFeatureGate.Set(featureGates); err != nil { | ||
| os.Exit(1) |
There was a problem hiding this comment.
Make sense, and I'll add another log error below the same time.:
k8s-ci-robot
added
the
needs-rebase
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, kerthcet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Signed-off-by: kerthcet <[email protected]>
Signed-off-by: kerthcet <[email protected]>
Signed-off-by: kerthcet <[email protected]>
kerthcet
force-pushed
the
feat/introduce-feature-gates
branch
from
dbe5a18
to
2058162
Compare
k8s-ci-robot
removed
the
needs-rebase
|
@tenzen-y can you review again? Rebased because of the go.mod conflicts. |
tenzen-y
reviewed
May 24, 2023
| @@ -308,14 +317,12 @@ func apply(configFile string) (ctrl.Options, config.Configuration, error) { | |||
| } | |||
| if len(errorlist) > 0 { | |||
| err := errorlist.ToAggregate() | |||
| setupLog.Error(err, "unknown framework", "available", jobframework.GetIntegrationsList()) | |||
There was a problem hiding this comment.
Nice work :)
The field.NotSupported returns a similar message.
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
/assign @alculquicondor
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #740
Special notes for your reviewer:
Does this PR introduce a user-facing change?