Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation about PrioritySortingWithinCohort feature #1597

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

yaroslava-serdiuk
Copy link
Contributor

What type of PR is this?

/kind documentation

Which issue(s) this PR fixes:

Fixes #1283

Does this PR introduce a user-facing change?

None

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 17, 2024
Copy link

netlify bot commented Jan 17, 2024

Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit 656a5f5
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/65a8340785c4ec0008a29df6
😎 Deploy Preview https://deploy-preview-1597--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 17, 2024
@yaroslava-serdiuk
Copy link
Contributor Author

/assign @tenzen-y

Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yaroslava-serdiuk Can we also add the explanations for the PrioritySortingWithinCohort?

I believe that we can describe this feature in the https://github.com/kubernetes-sigs/kueue/blob/98ec37470b09a3e11baf3de1f1759500c8af32d9/site/content/en/docs/concepts/cluster_queue.md#cohort.

@yaroslava-serdiuk
Copy link
Contributor Author

@tenzen-y added a note for the feature. I think it's enough, because the feature is a temporary (at some point we will graduate the feature, i.e. the feature is always enabled; you cannot disable it or deprecate the feature if we find another solution for workloads sorting).
cc @alculquicondor

Copy link
Contributor

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 17, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, yaroslava-serdiuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e7396564dd7ef234e97a16baa129bc776e792e0f

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2024
@k8s-ci-robot k8s-ci-robot merged commit d4d3f3b into kubernetes-sigs:main Jan 17, 2024
6 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.6 milestone Jan 17, 2024
kannon92 pushed a commit to openshift-kannon92/kubernetes-sigs-kueue that referenced this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not consider priorities when sorting workloads from different ClusterQueues
4 participants