-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation about PrioritySortingWithinCohort feature #1597
Conversation
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/assign @tenzen-y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yaroslava-serdiuk Can we also add the explanations for the PrioritySortingWithinCohort?
I believe that we can describe this feature in the https://github.com/kubernetes-sigs/kueue/blob/98ec37470b09a3e11baf3de1f1759500c8af32d9/site/content/en/docs/concepts/cluster_queue.md#cohort.
097cdc8
to
7bacad3
Compare
@tenzen-y added a note for the feature. I think it's enough, because the feature is a temporary (at some point we will graduate the feature, i.e. the feature is always enabled; you cannot disable it or deprecate the feature if we find another solution for workloads sorting). |
7bacad3
to
656a5f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, yaroslava-serdiuk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM label has been added. Git tree hash: e7396564dd7ef234e97a16baa129bc776e792e0f
|
What type of PR is this?
/kind documentation
Which issue(s) this PR fixes:
Fixes #1283
Does this PR introduce a user-facing change?