Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added guide for pod-level integration with Argo Workflows #1545

Closed
wants to merge 1 commit into from
Closed

Added guide for pod-level integration with Argo Workflows #1545

wants to merge 1 commit into from

Conversation

sam-leitch-oxb
Copy link

@sam-leitch-oxb sam-leitch-oxb commented Jan 3, 2024

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Adds documentation on how to integrate with Argo Workflows using plain pod management.

Which issue(s) this PR fixes:

Related to #74

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Added documentation on pod-level integration with Argo Workflows.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/documentation Categorizes issue or PR as related to documentation. labels Jan 3, 2024
Copy link

CLA Not Signed

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sam-leitch-oxb
Once this PR has been reviewed and has the lgtm label, please assign moficodes for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

netlify bot commented Jan 3, 2024

Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit 3c39267
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/6595db67cfcdbf0008a4141f
😎 Deploy Preview https://deploy-preview-1545--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 3, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @sam-leitch-oxb!

It looks like this is your first PR to kubernetes-sigs/kueue 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kueue has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @sam-leitch-oxb. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 3, 2024
@alculquicondor
Copy link
Contributor

Hi @sam-leitch-oxb, any reason why you closed this PR?

@chenxi-seu
Copy link

@alculquicondor Hi, there seems to be progressive strides towards amalgamating Argo workflow support with Kueue. I am very interested in this feature and was hoping to get some updates on its progress and any future plans. Could you please share any information about the current status or expected timelines?

@sam-leitch-oxb
Copy link
Author

Hi @sam-leitch-oxb, any reason why you closed this PR?

Need some time to get the CLA approved (using a corporate account)
I didn't want to hold up anything in the interim.

@tenzen-y
Copy link
Member

@alculquicondor Hi, there seems to be progressive strides towards amalgamating Argo workflow support with Kueue. I am very interested in this feature and was hoping to get some updates on its progress and any future plans. Could you please share any information about the current status or expected timelines?

@chenxi-seu You can track Argo integration at argoproj/argo-workflows#12363 and #74.

Copy link

@agilgur5 agilgur5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice guide, this is helpful!

I couldn't comment on the PR in-line as the fork was deleted (GH was throwing an error), so a comment below:

For the very last line: Did you mean plugin instead of resource?
http and plugin actually do create Pods, it's just not documented much (I found this out only after being a contributor for many months. it's very vaguely mentioned in the http template docs and manifests linked therein). They create an agent Pod if one does not exist in the Workflow's namespace. If one already exists, it gets re-used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants