-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added guide for pod-level integration with Argo Workflows #1545
Added guide for pod-level integration with Argo Workflows #1545
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sam-leitch-oxb The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Welcome @sam-leitch-oxb! |
Hi @sam-leitch-oxb. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @sam-leitch-oxb, any reason why you closed this PR? |
@alculquicondor Hi, there seems to be progressive strides towards amalgamating Argo workflow support with Kueue. I am very interested in this feature and was hoping to get some updates on its progress and any future plans. Could you please share any information about the current status or expected timelines? |
Need some time to get the CLA approved (using a corporate account) |
@chenxi-seu You can track Argo integration at argoproj/argo-workflows#12363 and #74. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice guide, this is helpful!
I couldn't comment on the PR in-line as the fork was deleted (GH was throwing an error), so a comment below:
For the very last line: Did you mean plugin
instead of resource
?
http
and plugin
actually do create Pods, it's just not documented much (I found this out only after being a contributor for many months. it's very vaguely mentioned in the http
template docs and manifests linked therein). They create an agent
Pod if one does not exist in the Workflow's namespace. If one already exists, it gets re-used.
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Adds documentation on how to integrate with Argo Workflows using plain pod management.
Which issue(s) this PR fixes:
Related to #74
Special notes for your reviewer:
Does this PR introduce a user-facing change?