Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add labels to the Workload object matching the job details #992

Closed
2 of 3 tasks
alculquicondor opened this issue Jul 17, 2023 · 3 comments · Fixed by #1032
Closed
2 of 3 tasks

Add labels to the Workload object matching the job details #992

alculquicondor opened this issue Jul 17, 2023 · 3 comments · Fixed by #1032
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@alculquicondor
Copy link
Contributor

What would you like to be added:

The name of a Workload doesn't match the name of the Job, to avoid collisions among different CRDs.

As a result, it's hard to quickly obtain the Workload for a particular job. A pair of labels (for name and GVK) would make it feasible to query.

Why is this needed:

For general usability and also to efficiently implement a CLI that gives you all relevant information for a job #487

Completion requirements:

This enhancement requires the following artifacts:

  • Design doc
  • API change
  • Docs update

The artifacts should be linked in subsequent comments.

@alculquicondor alculquicondor added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 17, 2023
@achernevskii
Copy link
Contributor

/assign

@trasc
Copy link
Contributor

trasc commented Jul 18, 2023

isn't the owner reference sufficient?

@alculquicondor
Copy link
Contributor Author

It's sufficient for a controller (like kueue) which watches every Workload object and is able to maintain an index.
OTOH, a CLI would have to call List and filter client-side to find the corresponding workload. A label allows to do the filtering server-side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants