Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply LimitRange validation on workloads. #612

Closed
3 tasks
Tracked by #636
trasc opened this issue Mar 7, 2023 · 3 comments · Fixed by #613
Closed
3 tasks
Tracked by #636

Apply LimitRange validation on workloads. #612

trasc opened this issue Mar 7, 2023 · 3 comments · Fixed by #613
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@trasc
Copy link
Contributor

trasc commented Mar 7, 2023

What would you like to be added:
This is a followup of #541.

The reasons is to limit the changes done in #600 and reach a decision for:

  1. What should happen if/when the LimitRange based validation fails.
  • For batch/jobs the strategy is to record an event and retry the pod creation.

Why is this needed:

Completion requirements:

This enhancement requires the following artifacts:

  • Design doc
  • API change
  • Docs update

The artifacts should be linked in subsequent comments.

cc: @alculquicondor @mwielgus

@trasc trasc added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 7, 2023
@trasc
Copy link
Contributor Author

trasc commented Mar 7, 2023

#613 Contains a partial (work in progress) implementation for this.

@alculquicondor
Copy link
Contributor

I didn't check the code, but my idea is:

  1. Fail in the Workload webhook.
  2. Record the failure as an event in the job controller.

@trasc
Copy link
Contributor Author

trasc commented Apr 5, 2023

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants