-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider LimitRanges when calculating Workload usage #541
Comments
/assign |
1 similar comment
/assign |
@alculquicondor Maybe the workload web-hook is not the best way to add this, since we'll need tho adapt the fix for #590. |
a. This means that we would have to do the same for every custom job API (mpi, ray, etc), which adds more complexity to integrations. You can work independently from #590. Whichever PR is ready later will have to rebase. |
cc @kerthcet After some offline discussion, we believe it's better to have a "totalRequests" field in the status. This can be calculated during admission and added in the same API call. This means we don't need to recreate or update the Workloads if LimitRanges or RuntimeClass changes. |
So we'll only update the totalRequests in admission, and after admission, we'll skip the calculation to avoid querying the limitRange, right? Then we can also solve the bug here #590 |
That is correct, that would solve #590 too. After admission, we would use the calculated requests in the cache. |
This is solved? What about the field |
What would you like to be added:
Administrators can setup LimitRanges per namespace to set default requests for Pods.
We should consider these defaults when creating a Workload.
It can be done in the Workload webhook so that it applies to any custom job, similar to #316.
Caveat: if a LimitRange is created after the Workload object is created, we will not have an accurate calculation of requests.
This issue is an spinoff from #485
Why is this needed:
LimitRanges are a common tool for admins to set defaults for a namespace.
Completion requirements:
This enhancement requires the following artifacts:
The artifacts should be linked in subsequent comments.
The text was updated successfully, but these errors were encountered: