-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle changing Job parallelism #467
Comments
We could have a short term solution: handle scale down properly and disallow scale up via webhook. |
Note that in the job controller, if parallelism changes, the job gets suspended and the workload object gets deleted, and so forcing re-queueing the job.
|
/assign @mwielgus |
This is already handled, what else do we want to do with this one? |
I think we want to think of this in the context of #77, not as a separate issue. |
/close |
@alculquicondor: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What would you like to be added:
Handle the change in parallelism. Before admission, this is simple: we need to update the workload.
What if the workload is already admitted? If there is enough quota, we could directly update the workload, even though that might violate FIFO semantics. Perhaps we will need to use scheduling gates to hold pods.
Why is this needed:
Parallelism is a mutable field.
Completion requirements:
This enhancement requires the following artifacts:
The artifacts should be linked in subsequent comments.
The text was updated successfully, but these errors were encountered: