Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate the retryDelayMinutes from the AdmissionCheck API #2437

Closed
1 task
PBundyra opened this issue Jun 18, 2024 · 4 comments · Fixed by #3203
Closed
1 task

Deprecate the retryDelayMinutes from the AdmissionCheck API #2437

PBundyra opened this issue Jun 18, 2024 · 4 comments · Fixed by #3203
Assignees
@mbobrovskyi
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@PBundyra
Copy link
Contributor

What would you like to be added:
Deprecate the retryDelayMinutes from the AdmissionCheck API

Why is this needed:
It is not used anywhere in the codebase

Completion requirements:

This enhancement requires the following artifacts:

  • Docs update

The artifacts should be linked in subsequent comments.
@PBundyra PBundyra added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 18, 2024
@PBundyra PBundyra mentioned this issue Jun 18, 2024
Open
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 16, 2024
@mimowo
Copy link
Contributor

mimowo commented Sep 16, 2024

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 16, 2024
@tenzen-y
Copy link
Member

I'm wondering if we can provide the v1beta2 AdmissionCheck API since we can easily provide the conversion webhooks between v1beta1 and v1beta2 AdmissionChecks.

@mbobrovskyi
Copy link
Contributor

/assign

@mimowo mimowo mentioned this issue Oct 7, 2024
Closed
@mbobrovskyi mbobrovskyi mentioned this issue Oct 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbobrovskyi mbobrovskyi

Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update "KEP-993: Two Stage Admission Process". epam/kubernetes-kueue
6 participants
@mimowo @mbobrovskyi @k8s-ci-robot @k8s-triage-robot @tenzen-y @PBundyra