Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It seems like the wrong function is being used when a multiKueueCluster is created #2117

Closed
leprode opened this issue May 3, 2024 · 1 comment · Fixed by #2165
Closed
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@leprode
Copy link

leprode commented May 3, 2024

What happened:
when a multiKueueCluster is created, the function named queueReconcileForConfigUsers is used directly in admissioncheck.go#L270

What you expected to happen:
the function named queue(admissioncheck.go#L313) should be used, then the function named queueReconcileForConfigUsers used in queue function.

How to reproduce it (as minimally and precisely as possible):
when a multiKueueCluster is created

Anything else we need to know?:

func (m *mkClusterHandler) Create(ctx context.Context, event event.CreateEvent, q workqueue.RateLimitingInterface) {
mkc, isMKC := event.Object.(*kueuealpha.MultiKueueCluster)
if !isMKC {
return
}
if err := queueReconcileForConfigUsers(ctx, mkc.Name, m.client, q); err != nil {
ctrl.LoggerFrom(ctx).V(2).Error(err, "Failure on create event", "multiKueueCluster", klog.KObj(mkc))
}
}

Environment:

  • Kubernetes version (use kubectl version):
  • Kueue version (use git describe --tags --dirty --always):
  • Cloud provider or hardware configuration:
  • OS (e.g: cat /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:
@leprode leprode added the kind/bug Categorizes issue or PR as related to a bug. label May 3, 2024
@trasc
Copy link
Contributor

trasc commented May 8, 2024

Thanks @leprode

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants